PolyMath 1.0

[Serge Stinckwich]

dear all,

I would like to push PolyMath 1.0 before ESUG 2018.

I create a milestone on github with some issues:
https://github.com/PolyMathOrg/PolyMath/issues?q=is%3Aopen+is%3Aissue+milestone%3A%221.0+%28codename+Cagliari%29%22

Do you want to add more ?

Who want to help ?

Thank you.

​Regards,​

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

http://www.doesnotunderstand.org/

[Serge Stinckwich]

Nobody to help ?

[Offray Vladimir Luna Cárdenas]

Sorry, writing my final PhD dissertation right now and with little time for anything else. But congrats on this new release and hopefully you'll find some help to make a release soon and thanks for all the work behind PolyMath.

Cheers,

Offray

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Hemal Varambhia]

Hi, Serge.

I loaded the project on to my distribution of Pharo. I ran the PMPolynomialsTest and noticed the testPolynomialNumberAdditionInverse are failing.

I'd love to work on getting this passing. Is this something that needs to be ready for v1.0 of PolyMath? If so, do I just create an issue and get going?

I'm new to Smalltalk (I've been toying with it for 6 months but part-time) and I would love to contribute in some way to your project.

Yours sincerely,

Hemal

[Serge Stinckwich]

On Wed, Jun 27, 2018 at 4:12 PM Hemal Varambhia <h.n.va...@gmail.com> wrote:

Hi, Serge.

​hi Hemal,

​

I loaded the project on to my distribution of Pharo. I ran the PMPolynomialsTest and noticed the testPolynomialNumberAdditionInverse are failing.

​There is some red tests in last CI:

https://travis-ci.org/PolyMathOrg/PolyMath

​but this is method is green on my computer. Are you running on Pharo 6.1 ? Which computer ?

I'd love to work on getting this passing. Is this something that needs to be ready for v1.0 of PolyMath? If so, do I just create an issue and get going?

​Yes sure, ​you are welcome to create an issue if there is test failure.

For the release v1.0, we want all tests to be green :-)

I'm new to Smalltalk (I've been toying with it for 6 months but part-time) and I would love to contribute in some way to your project.

​This is great ! There is lot of tasks that can be done even for a Pharo beginner :-)

​Thank you for your contribution to PolyMath !​

​A+​

[Hemal Varambhia]

Hi, Serge.

I should have been clearer, sorry. It turns out that I'm running Pharo 6.0 when I look at the system's 'about' window. I'll try to update first! I'm running my distribution on Ubuntu 16.04. The test was failing because it claims that instances of PMPolynomials are not Indexable. Let me get back to you.

Hemal

[Serge Stinckwich]

ok, this is better to try PolyMath on Pharo 6.1 or Pharo 7.0.

On Wed, Jun 27, 2018 at 4:32 PM Hemal Varambhia <h.n.va...@gmail.com> wrote:

Hi, Serge.

I should have been clearer, sorry. It turns out that I'm running Pharo 6.0 when I look at the system's 'about' window. I'll try to update first! I'm running my distribution on Ubuntu 16.04. The test was failing because it claims that instances of PMPolynomials are not Indexable. Let me get back to you.

Hemal

On Wednesday, June 27, 2018 at 4:22:55 PM UTC+1, Serge Stinckwich wrote:

On Wed, Jun 27, 2018 at 4:12 PM Hemal Varambhia <h.n.va...@gmail.com> wrote:

Hi, Serge.

​hi Hemal,

​

I loaded the project on to my distribution of Pharo. I ran the PMPolynomialsTest and noticed the testPolynomialNumberAdditionInverse are failing.

​There is some red tests in last CI:

https://travis-ci.org/PolyMathOrg/PolyMath

​but this is method is green on my computer. Are you running on Pharo 6.1 ? Which computer ?

I'd love to work on getting this passing. Is this something that needs to be ready for v1.0 of PolyMath? If so, do I just create an issue and get going?

​Yes sure, ​you are welcome to create an issue if there is test failure.

For the release v1.0, we want all tests to be green :-)

I'm new to Smalltalk (I've been toying with it for 6 months but part-time) and I would love to contribute in some way to your project.

​This is great ! There is lot of tasks that can be done even for a Pharo beginner :-)

​Thank you for your contribution to PolyMath !​

​A+​

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

http://www.doesnotunderstand.org/

--

You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Hemal Varambhia]

Serge,

Of course you're right. The test is green now.

I would like to try 

https://github.com/PolyMathOrg/PolyMath/issues/48 - it seems not to have been assigned to anyone yet and it feels like something I could do. Where do I go from here in terms of workflow and submitting code?

Hemal

[Serge Stinckwich]

ok thank you Hemal for your help !

Can you wait a little bit ? Stephane should move the code on github and should avoid to commit code during that time.

Do you have a github ID so I add you to the PolyMath org ?

Regards,

[Hemal Varambhia]

Hi, Serge

My github ID is hemalvarambhia. Thank you for adding me.

Hemal

[Serge Stinckwich]

You have been added !

[Hemal Varambhia]

Dear Serge,

I have question around the workflow for contributing code to PolyMath. I've assigned myself an issue now (#48). I am aware I should publish a PR for the issue I'm working on, but should I branch off of master, since there's no development branch yet?

Hemal

[Serge Stinckwich]

On Sun, Jul 1, 2018 at 10:33 AM Hemal Varambhia <h.n.va...@gmail.com> wrote:

Dear Serge,

​Dear Hemal,

​

 

I have question around the workflow for contributing code to PolyMath. I've assigned myself an issue now (#48). I am aware I should publish a PR for the issue I'm working on, but should I branch off of master, since there's no development branch yet?

​At the moment there is no dev branch. We will do one before the 1.0 version release I guess.

Until now, you can fork the main branch and send PR on this branch.

Regards,

[Hemal Varambhia]

Dear Serge,

That's awesome. Thank you. I've created a branch from master 

https://github.com/PolyMathOrg/PolyMath/tree/hemalvarambhia-issue-48. 

I moved the QuaternionExtension class and instance messages over to the Quaternion package over two commits (I wanted to take microsteps). I ran the tests on Pharo and they're still green. Would the next step be to just delete the Math-QuaternionExtensions package from the file system entirely?

Hemal

[Hemal Varambhia]

Serge,

I guess, just in case I wasn't clear. would I now, following my two commits on the said branch, be able to 'Remove the package from disk,' as per the Iceberg option?

Hemal

[Serge Stinckwich]

On Mon, Jul 2, 2018 at 10:54 PM Hemal Varambhia <h.n.va...@gmail.com> wrote:

Dear Serge,

That's awesome. Thank you. I've created a branch from master 

https://github.com/PolyMathOrg/PolyMath/tree/hemalvarambhia-issue-48. 

I moved the QuaternionExtension class and instance messages over to the Quaternion package over two commits (I wanted to take microsteps). I ran the tests on Pharo and they're still green. Would the next step be to just delete the Math-QuaternionExtensions package from the file system entirely?

​Thank you Hemal for your contribution. Apparently you commit directly on the repository without doing a PR.

I think ​this is better to create PR, because can comment and see them more easily than commits on branches.

I create a PR from your commit here:

https://github.com/PolyMathOrg/PolyMath/pull/58

[Serge Stinckwich]

On Mon, Jul 2, 2018 at 11:03 PM Hemal Varambhia <h.n.va...@gmail.com> wrote:

Serge,

I guess, just in case I wasn't clear. would I now, following my two commits on the said branch, be able to 'Remove the package from disk,' as per the Iceberg option?

​I don't understand sorry ?

Yes we have to remove the package.

[Hemal Varambhia]

Hi, Serge

As you mentioned in the PR, I have now merged the packages specified in QuaternionExtensions into Quaternion in the BaselineOfPolyMath class, and deleted the QuanternionExtensions package from the project entirely. I just pushed my changes up to the remote branch.

However, I found one reference to the QuaternionExtensions package in the BaselineOfPolyMath class in the groups section:

group: 'Extensions' with: #('Math-Clustering' 'Math-Number-Extensions' 'Math-QuaternionExtensions' 'Math-Chromosome' 'Math-PrincipalComponentAnalysis' 'Math-FunctionFit'

Can that item in the array (Math-QuaternionExtensions) be removed as well?

Otherwise I think the PR is ready for review. 

Again, thank you for taking the time to help me and answering my (presumeably very basic) questions. Hopefully they weren't too annoying!

Hemal

[Hemal Varambhia]

Serge,

Looks like Smalltalk complained:

Loading baseline of BaselineOfPolyMath...Error: Name not found: Math-QuaternionExtensions

I have now pushed up a correction.

Hemal