--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPf%2BwJ-hR29Zc7FUJX8PHB7cJXG91rm-HM72oq4nVF_faw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
"Programs must be written for people to read, and only incidentally for machines to execute." https://twitter.com/SergeStinckwich |
--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/10349477-0da2-4803-991b-b3d8236b1138%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/CABgoFPfX5VhKwO7hHmpyD%3D3X6AUD9%2BL4pmVtM%2BabLRRTNobxrg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Werner and Serge,As mentioned earlier in the chain the refactoring PR is now ready for your perusal:Please review when you have energy and capacity. The key thing to mention here is that the ifNone clause in findKey now yields an empty string. This way any client using this code is guaranteed to get a string back and won't have to resort to null checks. Of course this isn't final and your advice/review on this would be very helpful.Once this is accepted and merged, I will proceed to get the Math-Accuracy package under test coverage for us as a new PR.Thank you, Werner, for helping to unblock me.Yours sincerely,Hemal
On Tue, 16 Jul 2019 at 10:57, Hemal Varambhia <h.n.v...@gmail.com> wrote:
Dear Werner,That was my initial thought, to have findKey not throw an error but I wanted to check with you first. No clients are relying on the package currently so this looks like it'd be safe. I will make that change and ask you and Serge to review the PR if you have capacity and energy.In terms of local setup and reproducing the error in that link, use the instructions here. I recommend you checkout the development branch.Yours sincerely,Hemal
On Tue, 16 Jul 2019 at 09:42, werner kassens <werne...@gmail.com> wrote:
Hi Hemal,--
<stupid grin> that link does not help me, since i dont know how to load the necessary things. but if you find the error in findkey (i have no idea why i added that, but i guess it should help me to use Accuracy correctly) too restrictive, then simply throw it away.wernerOn Sunday, July 14, 2019 at 4:58:49 PM UTC+2, Hemal Varambhia wrote:Werner,Thank you for replying so quickly. The actual problem I'm experiencing is shown in the link below:It comes from the error raised in findKey. Does that really need to throw an error?Hemal
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/2055e038-d2ed-4d40-9b8a-5e47120343a8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--"Musbury",
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL
Home: +44 (0) 208 346 6444
Mobile: +44 (0) 7751 879 908
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/7d275e3a-99f3-4ff6-9ac9-332cd5249fc7%40googlegroups.com.
Werner,
--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/a5ee46b3-b2fb-47cf-8a6b-854606358624%40googlegroups.com.
Werner,Could you send me the failing code and steps to reproduce the problem?Hemal
On Wed, 17 Jul 2019, 12:56 werner kassens, <werne...@gmail.com> wrote:
--Hi Hemal,yes. btw if my recollection is correct you made a few other earlier changes i hadnt looked at, it is possible that one of them lead to that result.werner
On Wednesday, July 17, 2019 at 1:09:52 PM UTC+2, Hemal Varambhia wrote:Werner,You mean delete the Math-Accuracy package entirely from PolyMath?Hemal
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath...@googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/9b61f432-c0b6-4677-970f-0d24456e00d1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/polymath-project/ba4456d4-3e1f-4e0c-a87a-8337a01bdc75%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Werner,