[Bug 51945] New: 13.0.0-rc3: LTO exposes new code warnings

[bugzill...@llvm.org]

Bug ID	51945
Summary	13.0.0-rc3: LTO exposes new code warnings
Product	Polly
Version	unspecified
Hardware	PC
OS	Windows NT
Status	NEW
Severity	enhancement
Priority	P
Component	Other
Assignee	poll...@googlegroups.com
Reporter	kloczko...@gmail.com
CC	llvm...@lists.llvm.org

Summary stats:

[tkloczko@barrel SPECS]$ rpmbuild -ba polly.spec --quiet 2>&1 | grep -- -W |
sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
     14 -Wmaybe-uninitialized

And detailes stderr log:

/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_ast.c:
In function 'isl_ast_expr_dup':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_ast.c:189:24:
warning: 'dup' may be used uninitialized in this function
[-Wmaybe-uninitialized]
  189 |                 return NULL;
      |                        ^
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_ast.c:162:23:
note: 'dup' was declared here
  162 |         isl_ast_expr *dup;
      |                       ^
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map_simplify.c:
In function 'isl_basic_map_drop_redundant_divs_ineq':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map_simplify.c:4759:
warning: 'last_neg' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 4759 |         if (ineq1 > ineq2) {
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map_simplify.c:5031:
note: 'last_neg' was declared here
 5031 |                 int last_pos, last_neg;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map_simplify.c:4745:
warning: 'last_pos' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 4745 |         isl_basic_map_inequality_to_equality(bmap, ineq);
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map_simplify.c:5031:
note: 'last_pos' was declared here
 5031 |                 int last_pos, last_neg;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/basis_reduction_templ.c:
In function 'isl_tab_compute_reduced_basis':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/basis_reduction_templ.c:57:
warning: 'row' may be used uninitialized in this function
[-Wmaybe-uninitialized]
   57 |         int row;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_ast_build.c:
In function 'isl_ast_build_insert_dim':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_ast_build.c:1556:
warning: 'space' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 1556 |         space = isl_space_map_from_set(space);
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_ast_build.c:1646:
note: 'space' was declared here
 1646 |         isl_space *space, *ma_space;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_schedule_tree.c:
In function 'subtree_schedule_extend':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_schedule_tree.c:1836:
warning: 'umap' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 1836 |         isl_union_map *umap;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_schedule_tree.c:
In function 'initial_domain':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_schedule_tree.c:1942:
warning: 'domain' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 1942 |         isl_union_set *domain;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_sample.c:
In function 'isl_set_sample_point':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_sample.c:1331:
warning: 'pnt' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 1331 |         return pnt;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_sample.c:1314:
note: 'pnt' was declared here
 1314 |         isl_point *pnt;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map_lexopt_templ.c:
In function 'basic_map_partial_lexopt_pw_multi_aff':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map_lexopt_templ.c:92:
warning: 'all_empty' may be used uninitialized in this function
[-Wmaybe-uninitialized]
   92 |         isl_set *all_empty;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map.c:
In function 'isl_map_partial_lexopt_aligned_pw_multi_aff':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map.c:3975:
warning: 'todo' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 3975 |         return set_from_map(isl_map_intersect(set_to_map(set1),
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map.c:7262:
note: 'todo' was declared here
 7262 |         isl_set *todo;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map.c:
In function 'isl_map_partial_lexopt_aligned':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_map_lexopt_templ.c:92:
warning: 'all_empty' may be used uninitialized in this function
[-Wmaybe-uninitialized]
   92 |         isl_set *all_empty;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_schedule_tree.c:
In function 'isl_schedule_tree_plain_is_equal':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_schedule_tree.c:683:
warning: 'equal' may be used uninitialized in this function
[-Wmaybe-uninitialized]
  683 |         if (equal < 0 || !equal)
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_scheduler.c:
In function 'compute_schedule_wcc':
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_scheduler.c:6089:
warning: 'best_dist' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 6089 |                         if (best_weight == weight && best_dist <= dist)
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_scheduler.c:6064:
note: 'best_dist' was declared here
 6064 |         int i, best = graph->n_edge, best_dist, best_weight;
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_scheduler.c:6089:
warning: 'best_weight' may be used uninitialized in this function
[-Wmaybe-uninitialized]
 6089 |                         if (best_weight == weight && best_dist <= dist)
      |
/home/tkloczko/rpmbuild/BUILD/polly-13.0.0rc3.src/lib/External/isl/isl_scheduler.c:6064:
note: 'best_weight' was declared here
 6064 |         int i, best = graph->n_edge, best_dist, best_weight;
      |

---

You are receiving this mail because:

• You are the assignee for the bug.

[bugzill...@llvm.org]

Michael Kruse changed bug 51945

What	Removed	Added
Resolution	---	MOVED
Status	NEW	RESOLVED
CC		ll...@meinersbur.de

Comment # 1 on bug 51945 from Michael Kruse

I forward the report to the upstream project:
https://groups.google.com/g/isl-development/c/sNpKTLW7sRw/m/sMC9vMGsBAAJ

Our CMakeLists.txt disables all warnings for upstream sources, I suggest to do
the same for the rpm build. Alternatively, build with POLLY_BUNDLED_ISL=OFF and
use the system's ISL (Debian prefers this).