[PATCH] D142580: [Polly] Remove Polly-ACC.

[Michael Kruse via Phabricator]

Meinersbur created this revision.
Meinersbur added a reviewer: grosser.
Meinersbur added a project: Polly.
Herald added subscribers: arphaman, javed.absar, kbarton, nemanjai.
Herald added a reviewer: bollu.
Herald added a project: All.
Meinersbur requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, sstefan1.
Herald added a project: LLVM.

Polly-ACC is unmaintained and since it has never been ported to the NPM pipeline, since D136621 <https://reviews.llvm.org/D136621> it is not even accessible anymore without manually specifying the passes on the `opt` command line.

Since there is no plan to put it to a maintainable state, remove it from Polly.


Repository:
rG LLVM Github Monorepo

https://reviews.llvm.org/D142580

Files:
polly/CMakeLists.txt
polly/CREDITS.txt
polly/cmake/CMakeLists.txt
polly/cmake/PollyConfig.cmake.in
polly/include/polly/CodeGen/PPCGCodeGeneration.h
polly/include/polly/CodeGen/RuntimeDebugBuilder.h
polly/include/polly/Config/config.h.cmake
polly/include/polly/LinkAllPasses.h
polly/include/polly/ScopInfo.h
polly/include/polly/Support/LinkGPURuntime.h
polly/lib/CMakeLists.txt
polly/lib/CodeGen/BlockGenerators.cpp
polly/lib/CodeGen/CodeGeneration.cpp
polly/lib/CodeGen/IslAst.cpp
polly/lib/CodeGen/ManagedMemoryRewrite.cpp
polly/lib/CodeGen/PPCGCodeGeneration.cpp
polly/lib/CodeGen/RuntimeDebugBuilder.cpp
polly/lib/External/CMakeLists.txt
polly/lib/External/ppcg/ChangeLog
polly/lib/External/ppcg/GIT_HEAD_ID
polly/lib/External/ppcg/README
polly/lib/External/ppcg/cpu.c
polly/lib/External/ppcg/cpu.h
polly/lib/External/ppcg/cuda.c
polly/lib/External/ppcg/cuda.h
polly/lib/External/ppcg/cuda_common.c
polly/lib/External/ppcg/cuda_common.h
polly/lib/External/ppcg/external.c
polly/lib/External/ppcg/gpu.c
polly/lib/External/ppcg/gpu.h
polly/lib/External/ppcg/gpu_array_tile.c
polly/lib/External/ppcg/gpu_array_tile.h
polly/lib/External/ppcg/gpu_group.c
polly/lib/External/ppcg/gpu_group.h
polly/lib/External/ppcg/gpu_hybrid.c
polly/lib/External/ppcg/gpu_hybrid.h
polly/lib/External/ppcg/gpu_print.c
polly/lib/External/ppcg/gpu_print.h
polly/lib/External/ppcg/gpu_tree.c
polly/lib/External/ppcg/gpu_tree.h
polly/lib/External/ppcg/grouping.c
polly/lib/External/ppcg/hybrid.c
polly/lib/External/ppcg/hybrid.h
polly/lib/External/ppcg/ocl_utilities.c
polly/lib/External/ppcg/ocl_utilities.h
polly/lib/External/ppcg/opencl.h
polly/lib/External/ppcg/opencl_test.sh.in
polly/lib/External/ppcg/polybench_test.sh.in
polly/lib/External/ppcg/ppcg.c
polly/lib/External/ppcg/ppcg.h
polly/lib/External/ppcg/ppcg_options.c
polly/lib/External/ppcg/ppcg_options.h
polly/lib/External/ppcg/print.c
polly/lib/External/ppcg/print.h
polly/lib/External/ppcg/schedule.c
polly/lib/External/ppcg/schedule.h
polly/lib/External/ppcg/tests/allow-sparse-copy-in.c
polly/lib/External/ppcg/tests/call.c
polly/lib/External/ppcg/tests/call2.c
polly/lib/External/ppcg/tests/call2_opencl_functions.cl
polly/lib/External/ppcg/tests/call3.c
polly/lib/External/ppcg/tests/call3_opencl_functions.cl
polly/lib/External/ppcg/tests/call_opencl_functions.cl
polly/lib/External/ppcg/tests/dead.c
polly/lib/External/ppcg/tests/iterator.c
polly/lib/External/ppcg/tests/live_out.c
polly/lib/External/ppcg/tests/local.c
polly/lib/External/ppcg/tests/loop.c
polly/lib/External/ppcg/tests/not_accessed.c
polly/lib/External/ppcg/tests/not_accessed_opencl_functions.cl
polly/lib/External/ppcg/tests/scalar.c
polly/lib/External/ppcg/tests/shared_sink.c
polly/lib/External/ppcg/tests/struct.c
polly/lib/External/ppcg/tests/struct2.c
polly/lib/External/ppcg/tests/struct3.c
polly/lib/External/ppcg/tests/struct4.c
polly/lib/External/ppcg/util.c
polly/lib/External/ppcg/util.h
polly/lib/External/ppcg/version.c
polly/lib/Support/RegisterPasses.cpp
polly/lib/Transform/ScheduleOptimizer.cpp
polly/test/GPGPU/Inputs/libdevice-functions-copied-into-kernel_libdevice.ll
polly/test/GPGPU/add-scalars-in-scop-to-kills.ll
polly/test/GPGPU/align-params-in-schedule.ll
polly/test/GPGPU/array-with-elem-type-smaller-than-byte.ll
polly/test/GPGPU/bounds-construction-with-ignore-param-bounds.ll
polly/test/GPGPU/cuda-annotations.ll
polly/test/GPGPU/cuda-managed-memory-simple.ll
polly/test/GPGPU/debug-metadata-leak.ll
polly/test/GPGPU/double-parallel-loop.ll
polly/test/GPGPU/failing-invariant-load-handling.ll
polly/test/GPGPU/failing-invariant-load-hoisting.ll
polly/test/GPGPU/host-control-flow.ll
polly/test/GPGPU/host-statement.ll
polly/test/GPGPU/ignore-parameter-bounds.ll
polly/test/GPGPU/intrinsic-copied-into-kernel.ll
polly/test/GPGPU/invalid-kernel-assert-verifymodule.ll
polly/test/GPGPU/invalid-kernel.ll
polly/test/GPGPU/invariant-load-array-access.ll
polly/test/GPGPU/invariant-load-escaping-values.ll
polly/test/GPGPU/invariant-load-hoisting-of-array.ll
polly/test/GPGPU/invariant-load-hoisting-read-in-kernel.ll
polly/test/GPGPU/invariant-load-hoisting-with-variable-bounds.ll
polly/test/GPGPU/invariant-load-hoisting-with-variable-lower-bound.ll
polly/test/GPGPU/invariant-load-hoisting-with-variable-upper-bound.ll
polly/test/GPGPU/invariant-load-hoisting.ll
polly/test/GPGPU/invariant-load-of-scalar.ll
polly/test/GPGPU/kernel-params-only-some-arrays.ll
polly/test/GPGPU/kernel-params-scop-parameter.ll
polly/test/GPGPU/kernels-names-across-scops-funcs.ll
polly/test/GPGPU/libdevice-functions-copied-into-kernel.ll
polly/test/GPGPU/live-range-reordering-with-privatization.ll
polly/test/GPGPU/loops-outside-scop.ll
polly/test/GPGPU/managed-memory-rewrite-alloca.ll
polly/test/GPGPU/managed-memory-rewrite-malloc-free-inside-constexpr.ll
polly/test/GPGPU/managed-memory-rewrite-malloc-free.ll
polly/test/GPGPU/memory-only-referenced-from-access.ll
polly/test/GPGPU/mostly-sequential.ll
polly/test/GPGPU/non-read-only-scalars.ll
polly/test/GPGPU/non-zero-array-offset.ll
polly/test/GPGPU/only-part-of-array-modified.ll
polly/test/GPGPU/parametric-loop-bound.ll
polly/test/GPGPU/partial_writes.ll
polly/test/GPGPU/partial_writes___%bb2---%bb14.jscop
polly/test/GPGPU/phi-nodes-in-kernel.ll
polly/test/GPGPU/private-memory.ll
polly/test/GPGPU/privatization-simple.ll
polly/test/GPGPU/privatization.ll
polly/test/GPGPU/region-stmt.ll
polly/test/GPGPU/remove-dead-instructions-in-stmt-2.ll
polly/test/GPGPU/remove-dead-instructions-in-stmt.ll
polly/test/GPGPU/run-time-check.ll
polly/test/GPGPU/scalar-param-and-value-32-bit.ll
polly/test/GPGPU/scalar-param-and-value-use.ll
polly/test/GPGPU/scalar-parameter-fp128.ll
polly/test/GPGPU/scalar-parameter-half.ll
polly/test/GPGPU/scalar-parameter-i120.ll
polly/test/GPGPU/scalar-parameter-i128.ll
polly/test/GPGPU/scalar-parameter-i3000.ll
polly/test/GPGPU/scalar-parameter-i80.ll
polly/test/GPGPU/scalar-parameter-ppc_fp128.ll
polly/test/GPGPU/scalar-parameter-x86_fp80.ll
polly/test/GPGPU/scalar-parameter.ll
polly/test/GPGPU/scalar-writes-in-scop-requires-abort.ll
polly/test/GPGPU/scheduler-timeout.ll
polly/test/GPGPU/shared-memory-scalar.ll
polly/test/GPGPU/shared-memory-two-dimensional.ll
polly/test/GPGPU/shared-memory.ll
polly/test/GPGPU/simple-managed-memory-rewrite.ll
polly/test/GPGPU/size-cast.ll
polly/test/GPGPU/spir-codegen.ll
polly/test/GPGPU/spir-typesize.ll
polly/test/GPGPU/unknown-fn-call-not-copied-into-kernel.ll
polly/test/GPGPU/untouched-arrays.ll
polly/test/Unit/lit.site.cfg.in
polly/test/lit.cfg
polly/test/lit.site.cfg.in
polly/tools/CMakeLists.txt
polly/tools/GPURuntime/CMakeLists.txt
polly/tools/GPURuntime/GPUJIT.c
polly/tools/GPURuntime/GPUJIT.h
polly/tools/GPURuntime/LICENSE.TXT
polly/www/documentation/gpgpucodegen.html
polly/www/index.html
polly/www/todo.html

[Phabricator]

Herald added a subscriber: ormris.

Repository:
rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142580/new/

https://reviews.llvm.org/D142580

[Nikita Popov via Phabricator]

nikic added a comment.

Looks like the patch might be inverted?

[Tobias Grosser via Phabricator]

grosser added a comment.

I think this is a great idea.

[Michael Kruse via Phabricator]

Meinersbur updated this revision to Diff 492459.
Meinersbur added a comment.

Invert patch.

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142580/new/

https://reviews.llvm.org/D142580

[Michael Kruse via Phabricator]

Meinersbur updated this revision to Diff 492460.
Meinersbur added a comment.

Also remove `pet.h`

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142580/new/

https://reviews.llvm.org/D142580

Files:
polly/CMakeLists.txt
polly/CREDITS.txt
polly/cmake/CMakeLists.txt
polly/cmake/PollyConfig.cmake.in
polly/include/polly/CodeGen/PPCGCodeGeneration.h
polly/include/polly/CodeGen/RuntimeDebugBuilder.h
polly/include/polly/Config/config.h.cmake
polly/include/polly/LinkAllPasses.h
polly/include/polly/ScopInfo.h
polly/include/polly/Support/LinkGPURuntime.h
polly/lib/CMakeLists.txt
polly/lib/CodeGen/BlockGenerators.cpp
polly/lib/CodeGen/CodeGeneration.cpp
polly/lib/CodeGen/IslAst.cpp
polly/lib/CodeGen/ManagedMemoryRewrite.cpp
polly/lib/CodeGen/PPCGCodeGeneration.cpp
polly/lib/CodeGen/RuntimeDebugBuilder.cpp
polly/lib/External/CMakeLists.txt

polly/lib/External/pet/include/pet.h

[Michael Kruse via Phabricator]

Meinersbur added a comment.

@grosser ping

[Tobias Grosser via Phabricator]

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

Lgtm, thank you.

[Michael Kruse via Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG19afbfe33156: [Polly] Remove Polly-ACC. (authored by Meinersbur).

Changed prior to commit:
https://reviews.llvm.org/D142580?vs=492460&id=503542#toc

Repository:
rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142580/new/

https://reviews.llvm.org/D142580

Files:
polly/CMakeLists.txt
polly/cmake/CMakeLists.txt
polly/cmake/PollyConfig.cmake.in
polly/docs/ReleaseNotes.rst