[PATCH] D98765: [Polly] Refactoring isReductionParallel() and getMinimalDependenceDistance() from Integer Set Libarary(ISL) to take the C++ wrapper

6 views
Skip to first unread message

Prateek Pardeshi via Phabricator

unread,
Mar 17, 2021, 10:45:43 AMMar 17
to prateekp...@gmail.com, ll...@meinersbur.de, siddu...@gmail.com, poll...@googlegroups.com, bhuvanend...@amd.com, 888...@gmail.com, lege...@outlook.com, micha...@web.de, doug...@gmail.com, jatin....@gmail.com, n...@google.com, wic...@vitalitystudios.com, michae...@gmail.com, phabr...@grosser.es
prateekpardeshi retitled this revision from "[Polly] Refractoring isReductionParallel() and getMinimalDependenceDistance() from Integer Set Libarary(ISL) to take the C++ wrapper" to "[Polly] Refactoring isReductionParallel() and getMinimalDependenceDistance() from Integer Set Libarary(ISL) to take the C++ wrapper".

Repository:
rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98765/new/

https://reviews.llvm.org/D98765

Prateek Pardeshi via Phabricator

unread,
Mar 17, 2021, 10:50:58 AMMar 17
to prateekp...@gmail.com, ll...@meinersbur.de, siddu...@gmail.com, poll...@googlegroups.com, llvm-c...@lists.llvm.org, bhuvanend...@amd.com, 888...@gmail.com, lege...@outlook.com, micha...@web.de, doug...@gmail.com, jatin....@gmail.com, n...@google.com, wic...@vitalitystudios.com, michae...@gmail.com, phabr...@grosser.es
prateekpardeshi updated this revision to Diff 331266.
prateekpardeshi added a comment.

Changes made:

- added `isl::pw_aff` to return in the function `getMinimalDependenceDistance()`


Repository:
rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98765/new/

https://reviews.llvm.org/D98765

Files:
polly/include/polly/CodeGen/IslAst.h
polly/lib/CodeGen/IslAst.cpp
polly/lib/CodeGen/IslNodeBuilder.cpp

D98765.331266.patch

Michael Kruse via Phabricator

unread,
Mar 24, 2021, 12:03:29 AMMar 24
to prateekp...@gmail.com, siddu...@gmail.com, poll...@googlegroups.com, llvm-c...@lists.llvm.org, bhuvanend...@amd.com, 888...@gmail.com, lege...@outlook.com, micha...@web.de, doug...@gmail.com, jatin....@gmail.com, n...@google.com, wic...@vitalitystudios.com, michae...@gmail.com, phabr...@grosser.es
Meinersbur added a comment.

In D98765#2631785 <https://reviews.llvm.org/D98765#2631785>, @prateekpardeshi wrote:

> Changes made:
> making changes in code

For future updates, could you be more detailed?



================
Comment at: polly/include/polly/CodeGen/IslAst.h:163-164
/// Get minimal dependence distance or nullptr if not available.
static __isl_give isl_pw_aff *
- getMinimalDependenceDistance(__isl_keep isl_ast_node *Node);
+ getMinimalDependenceDistance(const isl::ast_node &Node);

----------------
Meinersbur wrote:
> For the refactoring of this function to be complete, can you also make it return a `isl::pw_aff`?
Removing `__isl_give` is not the change I asked for,

Michael Kruse via Phabricator

unread,
Mar 31, 2021, 3:47:01 PMMar 31
to prateekp...@gmail.com, siddu...@gmail.com, poll...@googlegroups.com, bhuvanend...@amd.com, 888...@gmail.com, lege...@outlook.com, micha...@web.de, doug...@gmail.com, jatin....@gmail.com, n...@google.com, wic...@vitalitystudios.com, michae...@gmail.com, phabr...@grosser.es
Meinersbur requested changes to this revision.
This revision now requires changes to proceed.
Reply all
Reply to author
Forward
0 new messages