[PATCH] D142640: [Polly] Remove -polly-vectorizer=polly.

[Michael Kruse via Phabricator]

Meinersbur created this revision.
Meinersbur added a reviewer: grosser.
Meinersbur added a project: Polly.
Herald added a reviewer: bollu.
Herald added a project: All.
Meinersbur requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, pcwang-thead, sstefan1.
Herald added a project: LLVM.

Polly's internal vectorizer is not well maintained and is known to not work in some cases such as region ScopStmts. Unlike LLVM's LoopVectorize pass it also does not have a target-dependent cost heuristics, and we recommend using LoopVectorize instead of -polly-vectorizer=polly.

In the future we hope that Polly can collaborate better with LoopVectorize, like Polly marking a loop is safe to vectorize with a specific simd width, instead of replicating its functionality.


Repository:
rG LLVM Github Monorepo

https://reviews.llvm.org/D142640

Files:
polly/include/polly/CodeGen/BlockGenerators.h
polly/include/polly/CodeGen/CodeGeneration.h
polly/include/polly/CodeGen/IslNodeBuilder.h
polly/lib/CodeGen/BlockGenerators.cpp
polly/lib/CodeGen/IslNodeBuilder.cpp
polly/lib/Support/RegisterPasses.cpp
polly/test/CodeGen/20130211-getNumberOfIterations.ll
polly/test/CodeGen/MemAccess/simple_analyze.ll
polly/test/CodeGen/MemAccess/simple_stride_test.ll
polly/test/CodeGen/OpenMP/scev-rewriting.ll
polly/test/CodeGen/getNumberOfIterations.ll
polly/test/CodeGen/if-conditions-in-vector-code.ll
polly/test/CodeGen/invariant_load_hoist_alignment.ll
polly/test/CodeGen/partial_write_mapped_vector.ll
polly/test/CodeGen/partial_write_mapped_vector___%for---%return.jscop
polly/test/CodeGen/partial_write_mapped_vector___%for---%return.jscop.transformed
polly/test/CodeGen/simple_vec_assign_scalar.ll
polly/test/CodeGen/simple_vec_assign_scalar_2.ll
polly/test/CodeGen/simple_vec_call.ll
polly/test/CodeGen/simple_vec_call_2.ll
polly/test/CodeGen/simple_vec_cast.ll
polly/test/CodeGen/simple_vec_const.ll
polly/test/CodeGen/simple_vec_large_width.ll
polly/test/CodeGen/simple_vec_ptr_ptr_ty.ll
polly/test/CodeGen/simple_vec_stride_negative_one.ll
polly/test/CodeGen/simple_vec_stride_one.ll
polly/test/CodeGen/simple_vec_stride_x.ll
polly/test/CodeGen/simple_vec_strides_multidim.ll
polly/test/CodeGen/simple_vec_two_stmts.ll
polly/test/CodeGen/stride_detection.ll
polly/test/ScheduleOptimizer/2012-04-16-Trivially-vectorizable-loops.ll
polly/test/ScheduleOptimizer/prevectorization-without-tiling.ll
polly/test/ScheduleOptimizer/prevectorization.ll
polly/test/ScheduleOptimizer/rectangular-tiling.ll
polly/test/ScheduleOptimizer/vec-addr-space.ll

[Tobias Grosser via Phabricator]

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

This makes a lot of sense to me too.

Repository:
rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142640/new/

https://reviews.llvm.org/D142640

[Nikita Popov via Phabricator]

nikic added a comment.

Reverse ping on landing this change. (It removes some `-opaque-pointers=0` tests, yay.)

[Usman Nadeem via Phabricator]

mnadeem added a reviewer: efriedma.

[Michael Kruse via Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG42cd38c01e5b: [Polly] Remove -polly-vectorizer=polly. (authored by Meinersbur).

Changed prior to commit:
https://reviews.llvm.org/D142640?vs=492461&id=503445#toc

Repository:
rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142640/new/

https://reviews.llvm.org/D142640

Files:
polly/docs/ReleaseNotes.rst