Makefile changes

0 views
Skip to first unread message

Rui Paulo

unread,
Oct 3, 2009, 5:15:00 PM10/3/09
to pmctools...@googlegroups.com
Hi,
I think that we should probably only install i386/amd64 man pages on
i386/amd64.

Something like this patch might do it (libpmc Makefile):

--- Makefile (revision 197703)
+++ Makefile (working copy)
@@ -24,6 +24,7 @@
MAN+= pmclog.3

# PMC-dependent manual pages
+.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "amd64"
MAN+= pmc.atom.3
MAN+= pmc.core.3
MAN+= pmc.core2.3
@@ -34,6 +35,9 @@
MAN+= pmc.p5.3
MAN+= pmc.p6.3
MAN+= pmc.tsc.3
+.endif

MLINKS+= \
pmc_allocate.3 pmc_release.3 \


What I wanted to do later was add something like:

.elif ${MACHINE_ARCH} == "arm" && ${CPUTYPE} == "xscale"
MAN+= pmc.xscale.3

What do you think?

Regards,
--
Rui Paulo

Joseph Koshy

unread,
Oct 4, 2009, 6:13:38 AM10/4/09
to pmctools...@googlegroups.com

> Hi,
> I think that we should probably only install i386/amd64 man pages on
> i386/amd64.

Good idea.

> Something like this patch might do it (libpmc Makefile):
>
> --- Makefile (revision 197703)
> +++ Makefile (working copy)
> @@ -24,6 +24,7 @@
> MAN+= pmclog.3
>
> # PMC-dependent manual pages
> +.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "amd64"
> MAN+= pmc.atom.3
> MAN+= pmc.core.3
> MAN+= pmc.core2.3
> @@ -34,6 +35,9 @@
> MAN+= pmc.p5.3
> MAN+= pmc.p6.3
> MAN+= pmc.tsc.3
> +.endif
>
> MLINKS+= \
> pmc_allocate.3 pmc_release.3 \
>
>
> What I wanted to do later was add something like:
>
> .elif ${MACHINE_ARCH} == "arm" && ${CPUTYPE} == "xscale"
> MAN+= pmc.xscale.3
>
> What do you think?
>
> Regards,
> --
> Rui Paulo

This should be fine, with the caveat that you might want to check
whether TARGET_ARCH or MACHINE_ARCH is the correct make(1) variable to
look at (for cross-builds).

Koshy

Reply all
Reply to author
Forward
0 new messages