Leaflet.DistortableImage test failing due to L.ToolbarAction.extend

208 views
Skip to first unread message

Jeffrey Warren

unread,
Jan 26, 2015, 3:16:34 PM1/26/15
to plot...@googlegroups.com, plots...@googlegroups.com
I'm getting a failed test on Leaflet.DistortableImage (i believe) once I began using the v0.1.0 of Leaflet.Toolbar:

PhantomJS 1.9.8 (Linux) ERROR
  TypeError: 'undefined' is not an object (evaluating 'L.ToolbarAction.extend')
  at /home/warren/sites/Leaflet.DistortableImage/src/edit/DistortableImage.EditToolbar.js:3
Chromium 39.0.2171 (Ubuntu) ERROR
  Uncaught TypeError: Cannot read property 'extend' of undefined
  at /home/warren/sites/Leaflet.DistortableImage/src/edit/DistortableImage.EditToolbar.js:3

Justin, or anyone else, know what this is about? I still see references to L.ToolbarAction.extend in Leaflet.Toolbar, but maybe I'm missing something. 

Thanks,
Jeff

Justin Manley

unread,
Jan 26, 2015, 3:25:49 PM1/26/15
to Jeffrey Warren, plot...@googlegroups.com, plots...@googlegroups.com
I'm going to take a look now.

Is this issue in the master branch of L.DistortableImage, or in a feature branch / on your personal repo?

Justin

--
You received this message because you are subscribed to the Google Groups "plots-gsoc" group.
To unsubscribe from this group and stop receiving emails from it, send an email to plots-gsoc+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Jeffrey Warren

unread,
Jan 26, 2015, 7:35:30 PM1/26/15
to Justin Manley, plots...@googlegroups.com, plot...@googlegroups.com

Master. But I believe (not 100%) that the change was not due to new code, but to bumping the version of .toolbar depended on.

You received this message because you are subscribed to the Google Groups "plots-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to plots-dev+...@googlegroups.com.

Justin Manley

unread,
Jan 26, 2015, 10:33:25 PM1/26/15
to Jeffrey Warren, plots...@googlegroups.com, plot...@googlegroups.com

Jeffrey Warren

unread,
Jan 27, 2015, 9:48:00 AM1/27/15
to Justin Manley, plots...@googlegroups.com, plot...@googlegroups.com
Awesome, Justin! :-)))))
Reply all
Reply to author
Forward
0 new messages