Issue 4 in plotkit: line graphs: going through 0,0 and maxX,0 seems errant; !shouldFill looks strange

[codesite...@google.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 4 by fgas...@freeshell.org: line graphs: going through 0,0 and
maxX,0 seems errant; !shouldFill looks strange
http://code.google.com/p/plotkit/issues/detail?id=4

Setting shouldFill = false tells PK not to fill in the line graphs;
however, the graph still has closed wire frame that:

1) starts at 0,0 (even if it’s not in the data set)
2) goes through each point of the data set (this is correct)
3) goes to the maxX,0 point (lower-right corner)
4) goes back to 0,0
5) is always white, regardless of the colorScheme setting

The expected behavior for non-filled line graphs would seem simply to be
going through each point with a line of the data set’s color.

Moreover, the filled line graphs should not go through 0,0 and maxX,0; they
should simply go down to the X axis from the first and last points of the
data set.

I am attaching a patch to SweetCanvas.js that resolves both of these issues
for that renderer.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[codesite...@google.com]

Comment #1 on issue 4 by fgas...@freeshell.org: line graphs: going through

0,0 and maxX,0 seems errant; !shouldFill looks strange
http://code.google.com/p/plotkit/issues/detail?id=4

(No comment was entered for this change.)

Attachments:
issue4.patch 3.4 KB