[Remember Mailing List] a bunch of changes, including partial uninstall, good citizenship, email login, plone4/membrane2 compat

0 views
Skip to first unread message

ken manheimer

unread,
Jun 4, 2011, 4:42:09 PM6/4/11
to Products.Remember mailing list
hi, all.  i've checked a bunch of substantial Products.remember changes into the products.remember trunk (svn browser), including:
  • an uninstall method that enables proper operation of non-remember accounts
  • prevention of disruption that Products.remember used to cause to portals that didn't have the product quick-installed
  • email login id that is controlled by the standard Site Setup / Security / "Use email address as login name" setting
  • Plone 4/membrane 2 compatibility (i think i checked that in and announced it a while back)
i'm running out of time to do much more, but am hoping to find a window to release it to pypi in the next few days.

the HISTORY.txt has many more details about the changes.

ken manheimer


--
Archive: http://www.coactivate.org/[…]/1307220145801
To unsubscribe send an email with subject "unsubscribe" to reme...@lists.coactivate.org. Please contact remember...@lists.coactivate.org for questions.

Maurits van Rees

unread,
Jun 5, 2011, 5:46:16 PM6/5/11
to reme...@lists.coactivate.org
Op 04-06-11 22:42, ken manheimer schreef:
hi, all.  i've checked a bunch of substantial Products.remember changes into the products.remember trunk (svn browser), including:
  • an uninstall method that enables proper operation of non-remember accounts
  • prevention of disruption that Products.remember used to cause to portals that didn't have the product quick-installed
  • email login id that is controlled by the standard Site Setup / Security / "Use email address as login name" setting
  • Plone 4/membrane 2 compatibility (i think i checked that in and announced it a while back)
i'm running out of time to do much more, but am hoping to find a window to release it to pypi in the next few days.

the HISTORY.txt has many more details about the changes.

Thanks a lot for your hard work, Ken!  Sorry, I have not tried the code, but the history at least looks like a good improvement.

So obviously what remains for me at the moment is minor nitpicking. ;-)  Why did you recently add the egg-info directory to subversion?  You mention in the changelog: "Some of this info is worth versioning, like PKG-INFO. Some might should be omitted."  All info in there is generated automatically from the existing code, mostly setup.py of course.  So I don't see a good reason to keep any of this in subversion.  Can you remove this again or explain why you would want to keep this?

In fact, I have '*.egg-info' in the global-ignores in my .subversion/config settings and I usually remember to put this in the svn:ignore property of a package too.

Thanks,

-- 
Maurits van Rees
Web App Programmer at Zest Software: http://zestsoftware.nl
Personal website: http://maurits.vanrees.org/

ken manheimer

unread,
Jun 5, 2011, 6:14:39 PM6/5/11
to reme...@lists.coactivate.org
On Sun, Jun 5, 2011 at 5:46 PM, Maurits van Rees <mau...@vanrees.org> wrote:
Op 04-06-11 22:42, ken manheimer schreef:
hi, all.  i've checked a bunch of substantial Products.remember changes into the products.remember trunk (svn browser), including:
  • an uninstall method that enables proper operation of non-remember accounts
  • prevention of disruption that Products.remember used to cause to portals that didn't have the product quick-installed
  • email login id that is controlled by the standard Site Setup / Security / "Use email address as login name" setting
  • Plone 4/membrane 2 compatibility (i think i checked that in and announced it a while back)
i'm running out of time to do much more, but am hoping to find a window to release it to pypi in the next few days.

the HISTORY.txt has many more details about the changes.

Thanks a lot for your hard work, Ken!  Sorry, I have not tried the code, but the history at least looks like a good improvement.

So obviously what remains for me at the moment is minor nitpicking. ;-)  Why did you recently add the egg-info directory to subversion?  You mention in the changelog: "Some of this info is worth versioning, like PKG-INFO. Some might should be omitted."  All info in there is generated automatically from the existing code, mostly setup.py of course.  So I don't see a good reason to keep any of this in subversion.  Can you remove this again or explain why you would want to keep this?

In fact, I have '*.egg-info' in the global-ignores in my .subversion/config settings and I usually remember to put this in the svn:ignore property of a package too.

thanks for the nitpicking, maurits - i knew that at least SOURCES.txt was generated, but didn't realize that's so for the entire egg-info dir.  (i should have realized - that explains a lot.)  i'll remove the egg-info from the repository and add back the egg-info exclusion to svn:ignore.

ken
 
Thanks,

-- 
Maurits van Rees
Web App Programmer at Zest Software: http://zestsoftware.nl
Personal website: http://maurits.vanrees.org/


--
Archive: http://www.coactivate.org/[…]/1307310377969
To unsubscribe send an email with subject "unsubscribe" to reme...@lists.coactivate.org. Please contact remember...@lists.coactivate.org for questions.

Reply all
Reply to author
Forward
0 new messages