[plcrashreporter] 2 new revisions pushed by landon.j.fuller@gmail.com on 2013-04-18 16:19 GMT

[codesite...@google.com]

2 new revisions:

Revision: e0ef74285be2
Author: Landon Fuller <lan...@bikemonkey.org>
Date: Thu Apr 18 09:10:10 2013
Log: Re-enable unit tests disabled in landonf-vm_remap-workaround....
http://code.google.com/p/plcrashreporter/source/detail?r=e0ef74285be2

Revision: 7bbab8d5fc7c
Author: Landon Fuller <lan...@bikemonkey.org>
Date: Thu Apr 18 09:18:32 2013
Log: Fix missing check for object mapping errors....
http://code.google.com/p/plcrashreporter/source/detail?r=7bbab8d5fc7c

==============================================================================
Revision: e0ef74285be2
Author: Landon Fuller <lan...@bikemonkey.org>
Date: Thu Apr 18 09:10:10 2013
Log: Re-enable unit tests disabled in landonf-vm_remap-workaround.

These tests were disabled when experimenting with in-place validation of
the target pages, but can be re-enabled now that we're using the
two-step equivalent of vm_remap().

http://code.google.com/p/plcrashreporter/source/detail?r=e0ef74285be2

Modified:
/Source/PLCrashAsyncMachOImageTests.m

=======================================
--- /Source/PLCrashAsyncMachOImageTests.m Tue Mar 26 12:42:48 2013
+++ /Source/PLCrashAsyncMachOImageTests.m Thu Apr 18 09:10:10 2013
@@ -194,10 +194,7 @@
uint8_t *mapped_data = plcrash_async_mobject_remap_address(&seg.mobj,
(pl_vm_address_t) data, segsize);
STAssertNotNULL(mapped_data, @"Could not get pointer for mapped data");

-#ifndef PL_HAVE_BROKEN_VM_REMAP
STAssertNotEquals(mapped_data, data, @"Should not be the same
pointer!");
-#endif
-
STAssertTrue(memcmp(data, mapped_data, segsize) == 0, @"The mapped
data is not equal");

/* Clean up */
@@ -228,11 +225,8 @@
/* Compare the contents */
uint8_t *mapped_data = plcrash_async_mobject_remap_address(&mobj,
(pl_vm_address_t) data, sectsize);
STAssertNotNULL(mapped_data, @"Could not get pointer for mapped data");
-
-#ifndef PL_HAVE_BROKEN_VM_REMAP
+
STAssertNotEquals(mapped_data, data, @"Should not be the same
pointer!");
-#endif
-
STAssertTrue(memcmp(data, mapped_data, sectsize) == 0, @"The mapped
data is not equal");

/* Clean up */

==============================================================================
Revision: 7bbab8d5fc7c
Author: Landon Fuller <lan...@bikemonkey.org>
Date: Thu Apr 18 09:18:32 2013
Log: Fix missing check for object mapping errors.

This code would incorrectly proceed in the case that an object mapping
could not be made.

http://code.google.com/p/plcrashreporter/source/detail?r=7bbab8d5fc7c

Modified:
/Source/PLCrashAsyncMachOString.c

=======================================
--- /Source/PLCrashAsyncMachOString.c Tue Jan 1 14:02:34 2013
+++ /Source/PLCrashAsyncMachOString.c Thu Apr 18 09:18:32 2013
@@ -59,6 +59,8 @@
/* Map in the page containing the string, +1 up to one additional
page. */
size_t page_count = 1;
plcrash_error_t err = plcrash_async_mobject_init(&string->mobj,
string->image->task, string->address, PAGE_SIZE);
+ if (err != PLCRASH_ESUCCESS)
+ return err;

char c;
do {