[plcrashreporter] push by landon.j.fuller@gmail.com - Remove userRequested additions.... on 2013-07-15 17:55 GMT

[codesite...@google.com]

Revision: c963fc04b4e8
Author: Landon Fuller <lan...@plausible.coop>
Date: Mon Jul 15 10:54:07 2013
Log: Remove userRequested additions.

These are unrelated to the incident identifier changes, and
we'll be exposing the report type (of which a 'live' report
is only one type) using a different model, as defined in the
crash_report_v2 ReportType enum.

http://code.google.com/p/plcrashreporter/source/detail?r=c963fc04b4e8

Modified:
/Source/PLCrashReport.h
/Source/PLCrashReport.m
/Source/PLCrashReportTests.m
/Source/PLCrashReportTextFormatter.m
/Source/PLCrashReporterTests.m

=======================================
--- /Source/PLCrashReport.h Thu Jul 11 14:35:46 2013
+++ /Source/PLCrashReport.h Mon Jul 15 10:54:07 2013
@@ -108,9 +108,6 @@
/** Exception information (may be nil) */
PLCrashReportExceptionInfo *_exceptionInfo;

- /** User requested not a crash */
- BOOL _userRequested;
-
/** Report UUID */
CFUUIDRef _uuid;
}
@@ -177,11 +174,6 @@
*/
@property(nonatomic, readonly) PLCrashReportExceptionInfo *exceptionInfo;

-/**
- * YES if this report was user requested not generated because of a crash.
- */
-@property(nonatomic, readonly) BOOL userRequested;
-
/**
* A client-generated 16-byte UUID. May be used to filter duplicate
reports submitted or generated
* by a single client. Only available in later (v1.2+) crash report format
versions. If not available,
=======================================
--- /Source/PLCrashReport.m Thu Jul 11 14:07:21 2013
+++ /Source/PLCrashReport.m Mon Jul 15 10:54:07 2013
@@ -93,11 +93,8 @@
}

/* Report info (optional) */
- _userRequested = NO;
_uuid = NULL;
if (_decoder->crashReport->report_info != NULL) {
- _userRequested =
_decoder->crashReport->report_info->user_requested;
-
/* Report UUID (optional)
* If our minimum supported target is bumped to (10.8+, iOS 6.0+),
NSUUID should
* be used instead. */
@@ -239,7 +236,6 @@
@synthesize threads = _threads;
@synthesize images = _images;
@synthesize exceptionInfo = _exceptionInfo;
-@synthesize userRequested = _userRequested;
@synthesize uuidRef = _uuid;

@end
=======================================
--- /Source/PLCrashReportTests.m Thu Jul 11 14:07:21 2013
+++ /Source/PLCrashReportTests.m Mon Jul 15 10:54:07 2013
@@ -122,7 +122,6 @@
STAssertNotNil(crashLog, @"Could not decode crash log: %@", error);

/* Report info */
- STAssertFalse(crashLog.userRequested, @"Crash should not be user
requested");
STAssertNotNULL(crashLog.uuidRef, @"No report UUID");

/* System info */
=======================================
--- /Source/PLCrashReportTextFormatter.m Thu Jul 11 14:35:46 2013
+++ /Source/PLCrashReportTextFormatter.m Mon Jul 15 10:54:07 2013
@@ -254,13 +254,6 @@

[text appendString: @"\n"];
}
-
- /* Was this user requested not a real crash? */
- if (report.userRequested) {
- [text appendString: @"Application Specific Information:\n"];
- [text appendString: @"*** User Requested Crash Report ***\n"];
- [text appendString: @"\n"];
- }

/* If an exception stack trace is available, output an
Apple-compatible backtrace. */
if (report.exceptionInfo != nil && report.exceptionInfo.stackFrames !=
nil && [report.exceptionInfo.stackFrames count] > 0) {
=======================================
--- /Source/PLCrashReporterTests.m Thu Jul 11 10:42:37 2013
+++ /Source/PLCrashReporterTests.m Mon Jul 15 10:54:07 2013
@@ -60,7 +60,6 @@
/* Try parsing the result */
PLCrashReport *report = [[PLCrashReport alloc] initWithData:
reportData error: &error];
STAssertNotNil(report, @"Could not parse geneated live report: %@",
error);
- STAssertTrue(report.userRequested, @"Report not marked user
requested");

/* Sanity check the signal info */
STAssertEqualStrings([[report signalInfo] name], @"SIGTRAP",
@"Incorrect signal name");
@@ -77,7 +76,6 @@

PLCrashReport *report = [[PLCrashReport alloc] initWithData:
reportData error: &error];
STAssertNotNil(report, @"Could not parse geneated live report: %@",
error);
- STAssertTrue(report.userRequested, @"Report not marked user
requested");

STAssertEqualStrings([[report signalInfo] name], @"SIGTRAP",
@"Incorrect signal name");
STAssertEqualStrings([[report signalInfo] code], @"TRAP_TRACE",
@"Incorrect signal code");