[2.0] Content-Disposition header is not being set on a file download
Simon Robins
The following code works beautifully apart from the fact that the content-disposition header is never set and the file gets downloaded with an incorrect name.
I have scoured the Java APIs but cannot see a way to set the header. I have tried to set it in the apply function but the response object is null at that point. I have tried setting the header in the index function but it is ignored. Can someone explain where I am going wrong please? Many thanks.
package controllers;
import java.io.File;
import java.util.concurrent.Callable;
import play.libs.Akka;
import play.libs.F;
import play.libs.F.Function;
import play.mvc.Controller;
import play.mvc.Result;
public class Application extends Controller
{
public static Result index()
{
F.Promise<File> promiseOfFile = Akka.future(new Callable<File>()
{
public File call()
{
return new File("temporaryfilename.txt");
}
});
response().setHeader("Content-Disposition", "attachment; filename=\"actualfilename.txt\"");
return async(promiseOfFile.map(new Function<File, Result>()
{
@Override
public Result apply(File file)
{
return ok(file);
}
}));
}
}
Kevin Bosman
> content-disposition header is never set and the file gets downloaded with an
> incorrect name.
>
> I have scoured the Java APIs but cannot see a way to set the header. I
> have tried to set it in the apply function but the response object is null
> at that point. I have tried setting the header in the index function but it
> is ignored. Can someone explain where I am going wrong please? Many thanks.
I do believe a fix may be in the pipeline for this Java problem (scala
does not exhibit the same problem due to some fundamental underlying
differences).
In the meantime, we've solved this problem as follows:
Within your async map Function, instead of directly returning
ok(file), you need to extract the wrapped scala result by calling
getWrappedResult() and cast it to play.api.mvc.PlainResult.
Once you have the underlying PlainResult, you can freely add headers,
flash, content-types, etc to it.
Now, because the PlainResult is immutable, when you're done you need
to *rewrap* it into a *new* play.mvc.Result Java object and return
that new instance from your async map Function.
Works like a charm :)
Guillaume Bort
> --
> You received this message because you are subscribed to the Google Groups
> "play-framework" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/play-framework/-/vLHFKFu9du4J.
> To post to this group, send email to play-fr...@googlegroups.com.
> To unsubscribe from this group, send email to
> play-framewor...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/play-framework?hl=en.
--
Guillaume Bort
Mike
Mike
I guess that nobody would want to use the Java API and also return a file content with a sensible name.
