Big problems after upgrading to play-1.2.3 (404 error)

[Peter S.]

Hi,

I upgraded my two play applications to 1.2.3 (play 1.2.2 was running
before). Afte the upgrade one of my applications doesn't work anymore.

I've some domains with subdomains, like www.xyz.de and abc.xyz.de.
After the upgrade, all requests to this domains results in notfound
errors (404).

Routfile:
-----------------
GET {domain}/? Application.index

Application.index:
-----------------------------
public static void index(String domain) {
Project project = Project.find("byDomain",domain).first();
notFoundIfNull(project);
render(project);
}

I logged the domain parameter. In the 1.2.2 version it is passed
correctly (like "www.xyz.de"), but in the 1.2.3 "{domain}" is passed.

Any idea what is changed in 1.2.3 that causes this error?

[Erwan Loisant]

Here is the list of changes (except for the security fix):
http://play.lighthouseapp.com/projects/57987-play-framework/milestones/current

This one looks like a good culprit:
http://play.lighthouseapp.com/projects/57987/tickets/603-virtual-host-routing-doesnt-work-on-default-port

Nicolas, can you take a look at is?

> --
> You received this message because you are subscribed to the Google Groups "play-framework" group.
> To post to this group, send email to play-fr...@googlegroups.com.
> To unsubscribe from this group, send email to play-framewor...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/play-framework?hl=en.
>
>

--
Erwan Loisant

[Nicolas Leroux]

I will have a look asap. Apparently the tests are not good enough as well ;)

Nicolas

[Nicolas Leroux]

This is fixed in master and on his way to the 1.2.x branch:

http://play.lighthouseapp.com/projects/57987-play-framework/tickets/1064-domain-in-routes-not-bind-anymore

Nicolas

[Peter S.]

Thank you for quick fixing, now it works very well :)

On Aug 25, 12:33 pm, Nicolas Leroux <leroux.nico...@gmail.com> wrote:
> This is fixed in master and on his way to the 1.2.x branch:
>

> http://play.lighthouseapp.com/projects/57987-play-framework/tickets/1...

>
> Nicolas
> On Aug 25, 2011, at 11:25 AM, Nicolas Leroux wrote:
>
> > I will have a look asap. Apparently the tests are not good enough as well ;)
>
> > Nicolas
> > On Aug 25, 2011, at 10:28 AM, Erwan Loisant wrote:
>
> >> Here is the list of changes (except for the security fix):

> >>http://play.lighthouseapp.com/projects/57987-play-framework/milestone...

>
> >> This one looks like a good culprit:

> >>http://play.lighthouseapp.com/projects/57987/tickets/603-virtual-host...

>
> >> Nicolas, can you take a look at is?
>

> >> On Thu, Aug 25, 2011 at 10:20, Peter S. <systemtroo...@web.de> wrote:
> >>> Hi,
>

> >>> I upgraded my two play applications to1.2.3(play 1.2.2 was running

> >>> before). Afte the upgrade one of my applications doesn't work anymore.
>

> >>> I've some domains with subdomains, likewww.xyz.deand abc.xyz.de.

> >>> After the upgrade, all requests to this domains results in notfound
> >>> errors (404).
>
> >>> Routfile:
> >>> -----------------
> >>> GET    {domain}/?  Application.index
>
> >>> Application.index:
> >>> -----------------------------
> >>> public static void index(String domain) {
> >>> Project project  = Project.find("byDomain",domain).first();
> >>> notFoundIfNull(project);
> >>> render(project);
> >>> }
>
> >>> I logged the domain parameter. In the 1.2.2 version it is passed

> >>> correctly (like "www.xyz.de"), but in the1.2.3"{domain}" is passed.
>
> >>> Any idea what is changed in1.2.3that causes this error?

>
> >>> --
> >>> You received this message because you are subscribed to the Google Groups "play-framework" group.
> >>> To post to this group, send email to play-fr...@googlegroups.com.
> >>> To unsubscribe from this group, send email to play-framewor...@googlegroups.com.

> >>> For more options, visit this group athttp://groups.google.com/group/play-framework?hl=en.

>
> >> --
> >> Erwan Loisant
>
> >> --
> >> You received this message because you are subscribed to the Google Groups "play-framework" group.
> >> To post to this group, send email to play-fr...@googlegroups.com.
> >> To unsubscribe from this group, send email to play-framewor...@googlegroups.com.

> >> For more options, visit this group athttp://groups.google.com/group/play-framework?hl=en.

[Brainztorm]

Hi players,

i've the same problem and would like to have a version of play with
this bug resolved.
I've cloned the github master branch, compiled it (master-8a4561d) but
the bug seems already here :/

any thoughts ?

Thanks in advance.

On Aug 25, 4:27 pm, "Peter S." <systemtroo...@web.de> wrote:
> Thank you for quick fixing, now it works very well :)
>
> On Aug 25, 12:33 pm, Nicolas Leroux <leroux.nico...@gmail.com> wrote:
>
>
>
>
>
>
>
> > This is fixed in master and on his way to the 1.2.x branch:
>
> >http://play.lighthouseapp.com/projects/57987-play-framework/tickets/1...
>
> > Nicolas
> > On Aug 25, 2011, at 11:25 AM, Nicolas Leroux wrote:
>

> > > I will have a look asap. Apparently the tests arenotgood enough as well ;)

>
> > > Nicolas
> > > On Aug 25, 2011, at 10:28 AM, Erwan Loisant wrote:
>
> > >> Here is the list of changes (except for the security fix):
> > >>http://play.lighthouseapp.com/projects/57987-play-framework/milestone...
>
> > >> This one looks like a good culprit:
> > >>http://play.lighthouseapp.com/projects/57987/tickets/603-virtual-host...
>
> > >> Nicolas, can you take a look at is?
>
> > >> On Thu, Aug 25, 2011 at 10:20, Peter S. <systemtroo...@web.de> wrote:
> > >>> Hi,
>
> > >>> I upgraded my two play applications to1.2.3(play 1.2.2 was running
> > >>> before). Afte the upgrade one of my applications doesn't workanymore.
>
> > >>> I've some domains with subdomains, likewww.xyz.deandabc.xyz.de.
> > >>> After the upgrade, all requests to this domains results in notfound
> > >>> errors (404).
>
> > >>> Routfile:
> > >>> -----------------
> > >>> GET    {domain}/?  Application.index
>
> > >>> Application.index:
> > >>> -----------------------------
> > >>> public static void index(Stringdomain) {
> > >>> Project project  = Project.find("byDomain",domain).first();
> > >>> notFoundIfNull(project);
> > >>> render(project);
> > >>> }
>

> > >>> I logged thedomainparameter. In the 1.2.2 version it is passed