validating a list of objects

[Alison Winters]

Hi guys,

I'm struggling with validating a list of bound objects. For example, I
have the following

public class Thing extends Model {
@Required
public String blob;
}

public class ThingFormPost {
@Required
public int numThings;

public List<Thing> things;
}

I have tried adding @Required and @Valid before the "things"
declaration and neither of these cause the individual Thing objects in
the list to be automatically validated. Is there any way to do this,
or do I have to manually iterate through the list and validate each
object like:

public class Things extends Controller {

public static postThings(ThingFormPost things) {
for (int i = 0; i < things.numThings; i++) {
validation.valid("things.things[" + i + "]",
things.things.get(i));
}
}
}

This way is kinda ugly, it'd be nice to avoid it if possible.

Alison

[Guillaume Bort]

Please add a feature request for that.

> --
> You received this message because you are subscribed to the Google Groups "play-framework" group.
> To post to this group, send email to play-fr...@googlegroups.com.
> To unsubscribe from this group, send email to play-framewor...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/play-framework?hl=en.
>
>

--
Guillaume Bort, http://guillaume.bort.fr

For anything work-related, use g...@zenexity.fr; for everything else,
write guillau...@gmail.com

[Alison Winters]

Thanks Guillaume, Lighthouse opened at:
http://play.lighthouseapp.com/projects/57987-play-framework/tickets/426-allow-automatic-validation-of-a-list-of-bound-objects

Alison

> Guillaume Bort,http://guillaume.bort.fr

>
> For anything work-related, use g...@zenexity.fr; for everything else,

> write guillaume.b...@gmail.com

[Mike | Vannik Software]

Hi,

It's nice that collections are supported. We have a case that looks like this:

public class MetaData {
    @Required(message = "validation.required.metaData.type")
    public String type;

    public String sourceUrl;
}

public class Item {
    public MetaData metaData;
}

Unfortunately, "type" in MetaData is not validated with the following method signature in a controller:

public static void save(@Valid Item item) {
}

Is there anything missing or is this kind of nested object validation not supported? We use Play 1.2.4.

> > To post to this group, send email to play-framework@googlegroups.​com.
> > To unsubscribe from this group, send email to play-framework+unsubscribe@​googlegroups.com.

[Mike | Vannik Software]

Does anyone have an idea on how to solve that?

Thanks

[Peter Hilton - committer (Lunatech)]

As far as I know, you can use @Valid more than once for the nesting, so add it to the nested property in Item. In other words, this might work:

public class Item {

    @Valid
    public MetaData metaData;
}

[Mike | Vannik Software]

Thanks Peter,

I've just looked into that again and it looks like there's also a @Required annotation necessary on the metaData property. In other words, if metaData is null, the @Required check throws an error.

If metaData is not null, but metaData.type is null, both the @Required check of the metaData.type and the @Valid annotation on the item.metaData property throw errors.

Cheers,

Mike