Play20 committers

[Ben McCann]

Hi,

I was going to suggest that some community members be invited as Play 2 contributors.  I've noticed the pull requests for Play 2 backing up quite a bit.  It can be frustrating because these are normally rather high priority fixes if people have cared enough about them to create fixes themselves.  However, I may be late in that suggestion since I see that James Roper was invited to the bug tracker and looks to have submitted a change in GitHub yesterday.  If James was indeed given commit access, then I'd like to say that this is a great move!  James was going to be one of the people I would have suggested myself given his past high-quality participation in the project.  I've also noticed Kevin Bosman as a quality contributor and I am sure there are many more.  I'd similarly be willing to help if there's anything I can do to help reduce the pull request backlog perhaps by testing and committing some of the less controversial pull requests.

-Ben

[Sadache Aldrobi]

It is just vacation time and we will be back to normal rhythm treating pull requests.

-Ben

--
You received this message because you are subscribed to the Google Groups "play-framework" group.
To view this discussion on the web visit https://groups.google.com/d/msg/play-framework/-/THl1SiYrhi4J.
To post to this group, send email to play-fr...@googlegroups.com.
To unsubscribe from this group, send email to play-framewor...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/play-framework?hl=en.

--
www.sadekdrobi.com
ʎdoɹʇuǝ

[Ben McCann]

Understandable :-)  Still let me know if there is anything I can do to help now or in the future!

-Ben

-- 
about.me/benmccann  

[James Roper]

Maybe this is an opportune time to announce that I have started working for Typesafe full time on Play framework?

[Ben McCann]

Congratulations on the new job James!  You're a great addition to Typesafe.  I'm very happy to see the Play team growing and that you're the newest member!  (Maybe if I suck up some more I can even get you to take a look at the pull request which I've been dying to have committed for the past couple months :-)

--
You received this message because you are subscribed to the Google Groups "play-framework" group.

To view this discussion on the web visit https://groups.google.com/d/msg/play-framework/-/I5us7fqk6YUJ.

To post to this group, send email to play-fr...@googlegroups.com.
To unsubscribe from this group, send email to play-framewor...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/play-framework?hl=en.

--
about.me/benmccann

[James Roper]

Congratulations on the new job James!  You're a great addition to Typesafe.  I'm very happy to see the Play team growing and that you're the newest member!  (Maybe if I suck up some more I can even get you to take a look at the pull request which I've been dying to have committed for the past couple months :-)

 

Thanks :)  I'm interested in that pull request too, add the ability to instantiate global with an Application injected into it, and it might be possible to write an app without ever relying on global vars (Play.current()).

[Ben McCann]

I think it'd be pretty feasible to add that (and a great idea too!).  We might need to move getControllerInstance out of Global though because otherwise it seems like it might create a bit cyclic.  On the pull request, Guillaume mentioned that he preferred getControllerInstance to reside in Global, but I'm not sure that either of us thought of this use case.  If you run the idea by him and he's okay with me putting it back in its own class, then I can look at updating the pull request to move towards what you suggested.

On Tue, Aug 28, 2012 at 9:41 AM, James Roper <jro...@gmail.com> wrote:

Congratulations on the new job James!  You're a great addition to Typesafe.  I'm very happy to see the Play team growing and that you're the newest member!  (Maybe if I suck up some more I can even get you to take a look at the pull request which I've been dying to have committed for the past couple months :-)

 

Thanks :)  I'm interested in that pull request too, add the ability to instantiate global with an Application injected into it, and it might be possible to write an app without ever relying on global vars (Play.current()).

--

You received this message because you are subscribed to the Google Groups "play-framework" group.

To view this discussion on the web visit https://groups.google.com/d/msg/play-framework/-/BdohKR3gcf4J.

To post to this group, send email to play-fr...@googlegroups.com.
To unsubscribe from this group, send email to play-framewor...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/play-framework?hl=en.

--
about.me/benmccann

[Manuel Bernhardt]

Congrats James!

And while you guys are discussing it: also my +1 on that very pull
request. I started using subcut recently, but given the rather static
controller architecture, it makes usage of injection in controllers a
bit cumbersome. Regarding the location of the "wire-it-all-together"
method: I just realized that it being located in Global might be a
problem for us, because we have a separate configuration plugin that
runs before Global and initializes the application configuration
(granted, this is a bit of a special case, it's dealing with
multi-tenancy).

It would be interesting if that "wire-it-all-together" method could
reside inside of a trait, and the implementations of that trait be
used (they could e.g. be specified in application.conf by class name,
and they could be required to be objects's rather than classes).

My 2 cents,

Manuel

[Ben McCann]

Guillaume gave the green light for the pull request to be merged.  I'll be eternally grateful if someone could do it.  It's already synced to the latest a couple of days ago, so it should be quite easy.

https://github.com/playframework/Play20/pull/365 

Thanks!

-Ben