External Device Container

[Mustafa Yuce]

Hi Lukas,

We have looked at your new "External Device" feature on plan44 vdcd. I think there is a problem in externaldevicecontainer.cpp line 629. Your code is 

bb->setHardwareButtonConfig(buttonId, buttonType, buttonElement, false, buttonElement_down ? 1 : 0, true); // fixed mode

But in my opinion code part must be like this ;

bb->setHardwareButtonConfig(buttonId, buttonType, buttonElement, false, buttonElement == buttonElement_down ? 1 : 0, true); // fixed mode

Could you please think about this issue?

Kind Regards,

Mustafa Yüce

[Lukas Zeller]

Hi Mustafa,

You are absolutely right, my code is wrong for the two-way button case, and your fix is correct.
I applied your patch, see the latest commit on luz on github. I also updated the docs, because a two way button must define the down element first, then the up element in order to work correctly.

Thanks a lot for reporting your discovery and the bugfix!

Best Regards,

Lukas