[pkgcore] #227: pmerge --clean --with-built-depends want to clean too much

[pkgcore]

#227: pmerge --clean --with-built-depends want to clean too much
--------------------------------+-------------------------------------------
Reporter: sschuberth | Owner:
Type: defect | Status: new
Priority: normal | Milestone: 0.4.7.14
Component: pkgcore | Version: 0.4.7.13
Keywords: clean dependencies |
--------------------------------+-------------------------------------------
I'm having "x11-libs/libXvMC-1.0.4" installed, which depends on "app-admin
/eselect-xvmc". Still,
{{{
pmerge --clean --with-built-depends --pretend
}}}
lists "app-admin/eselect-xvmc" (but not "x11-libs/libXvMC") as to be
cleaned. equery also says
{{{
# equery depends app-admin/eselect-xvmc
[ Searching for packages depending on app-admin/eselect-xvmc... ]
x11-libs/libXvMC-1.0.4 (app-admin/eselect-xvmc)
}}}
so I believe pkgcore is not getting the dependencies of "x11-libs/libXvMC"
right.

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/227>
pkgcore <http://www.pkgcore.org/trac/pkgcore>
pkgcore package manager

[pkgcore]

#227: pmerge --clean --with-built-depends want to clean too much
--------------------------------+-------------------------------------------
Reporter: sschuberth | Owner:
Type: defect | Status: new
Priority: normal | Milestone: 0.4.7.14
Component: pkgcore | Version: 0.4.7.13
Keywords: clean dependencies |
--------------------------------+-------------------------------------------

Comment(by ferringb):

Attach pmerge --clean -Bp --debug please

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/227#comment:1>

[pkgcore]

#227: pmerge --clean --with-built-depends want to clean too much

-------------------------+--------------------------------------------------
Reporter: sschuberth | Owner:
Type: defect | Status: closed

Priority: normal | Milestone: 0.4.7.14
Component: pkgcore | Version: 0.4.7.13

Resolution: invalid | Keywords: clean dependencies
-------------------------+--------------------------------------------------
Changes (by ferringb):

* status: new => closed
* resolution: => invalid

Comment:

Sorry for the delay... Current pkgcore I can confirm doesn't try removing
this, and the code behind that hasn't changed in a long while (longer than
this bug has been around), although the resolver has.

That said, for --clean to be wrong here would require pkgcore to be
selectively skipping PDEPEND in resolution- a bug I've never seen it do.
If you look in the logs for 'post_rdepends', you'll see it's actually
processing PDEPEND deps in doing this calculation.

What I think occurred here is a combination of timing, and equery lying to
you- note [http://sources.gentoo.org/cgi-
bin/viewvc.cgi/gentoo-x86/x11-libs/libXvMC/libXvMC-1.0.4.ebuild?r1=1.11&r2=1.12
rev 1.12] of libXvMC, which was commited about a month/2 before this
ticket. Up until that cvs rev, there wasn't a dep on eselect-xvmc.

Since the dep was added w/out ever actually revbumping the pkg (which is a
screwup on cardoe's part), that extra dependency never made it into the
vdb- so what you had installed didn't actually depend on eselect-xvmc.
Thus the clean algo was justified in trying to remove it.

As to why equery said otherwise, portage/equery both have a nasty habit of
trying to intermix dependency info from source pkgs onto binpkgs/vdb pkgs-
this isn't a valid practice, and isn't something pkgcore will ever do
(it'll support metadata updates, but not that half ass "hope for the best"
approach portage does). equery scanned the source tree, said that the
source version dep'd on it, while what you had installed didn't actually
dep on it.

Future reference, a
{{{
pquery --revdep app-admin/eselect-xvmc --vdb
}}}
Would've been the best way to find out what, in the vdb, actually deps on
it.

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/227#comment:2>

[pkgcore]

#227: pmerge --clean --with-built-depends want to clean too much

-------------------------+--------------------------------------------------
Reporter: sschuberth | Owner:
Type: defect | Status: closed

Priority: normal | Milestone: 0.4.7.14
Component: pkgcore | Version: 0.4.7.13

Resolution: invalid | Keywords: clean dependencies
-------------------------+--------------------------------------------------

Comment (by sschuberth):

Thanks for the detailed explanations!

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/227#comment:3>