[pkgcore] #172: remove os.access usage

[pkgcore]

#172: remove os.access usage
----------------------+-----------------------------------------------------
Reporter: Ramereth | Owner:
Type: defect | Status: new
Priority: normal | Milestone: 0.4.5
Component: pkgcore | Version: 0.4.4
Keywords: |
----------------------+-----------------------------------------------------
As requested by ferringb in #pkgcore, Please remove os.access usage in
pkgcore as there are some issues with it on SunOS. Specifically,
os.access(filename, os.X_OK) does not return the proper test case on
solaris. If you need more information, please let me know!

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/172>
pkgcore <http://www.pkgcore.org/trac/pkgcore>
pkgcore package manager

[pkgcore]

#172: remove os.access usage
-----------------------+----------------------------------------------------

Reporter: Ramereth | Owner:
Type: defect | Status: new
Priority: normal | Milestone: 0.4.5
Component: pkgcore | Version: 0.4.4

Resolution: | Keywords:
-----------------------+----------------------------------------------------
Comment (by Ramereth):

For documentation sake, here's the output of the test case:


{{{
======================================================================

FAIL: test_find_binary (pkgcore.test.test_spawn.SpawnTest)

----------------------------------------------------------------------

Traceback (most recent call last):

File "/usr/lib/python2.4/site-packages/snakeoil/test/__init__.py", line
171, in run

self.forced_extra_frame(testMethod)

File "/usr/lib/python2.4/site-packages/snakeoil/test/__init__.py", line
140, in forced_extra_frame

test()

File "/tmp/pkgcore-0.4.5/pkgcore/test/test_spawn.py", line 43, in
test_find_binary

self.assertRaises(spawn.CommandNotFound, spawn.find_binary,
script_name)

AssertionError: CommandNotFound not raised



----------------------------------------------------------------------

}}}

And as a simple test:

{{{
root@poplar / # touch foon; chmod 0640 foon; python -c 'import os;print
os.access("foon", os.X_OK)'
True
root@poplar / # ls -l foon
-rw-r----- 1 root 101 0 Apr 21 17:06 foon
}}}

So something is lying :-)

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/172#comment:1>

[pkgcore]

#172: remove os.access usage
-----------------------+----------------------------------------------------

Reporter: Ramereth | Owner:
Type: defect | Status: new

Priority: normal | Milestone: 0.4.7

Component: pkgcore | Version: 0.4.4
Resolution: | Keywords:
-----------------------+----------------------------------------------------

Changes (by ferringb):

* milestone: 0.4.5 => 0.4.7

Comment:

Bleh. this will be 0.4.7, sorry.

Got a set of fixups/features want to release, and frankly I don't want to
replace access quite yet (mainly since I'm dreading the logic ;). Will
attach a patch w/in a few days.

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/172#comment:2>

[pkgcore]

#172: remove os.access usage
-----------------------+----------------------------------------------------
Reporter: Ramereth | Owner:

Type: task | Status: new
Priority: normal | Milestone: 0.5

Component: pkgcore | Version: 0.4.4
Resolution: | Keywords:
-----------------------+----------------------------------------------------

Changes (by masterdriverz):

* type: defect => task

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/172#comment:3>

[pkgcore]

#172: remove os.access usage
-----------------------+----------------------------------------------------
Reporter: Ramereth | Owner:

Type: task | Status: new
Priority: normal | Milestone: 0.6

Component: pkgcore | Version: 0.4.4
Resolution: | Keywords:
-----------------------+----------------------------------------------------

Changes (by ferringb):

* milestone: 0.5 => 0.6

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/172#comment:4>

[pkgcore]

#172: remove os.access usage
-----------------------+----------------------------------------------------
Reporter: Ramereth | Owner:

Type: task | Status: closed

Priority: normal | Milestone: 0.6
Component: pkgcore | Version: 0.4.4

Resolution: fixed | Keywords:
-----------------------+----------------------------------------------------
Changes (by ferringb):

* status: new => closed
* resolution: => fixed

Comment:

bzr rev 4203 of my branch fixes this via snakeoil.osutils.access being
added; osutils.access defaults to being os.access if that implementation
is usable, else (say for SunOS) it uses a fallback implementation.

Crappy posix standards allow SunOS to be right from a spec standpoint,
although wrong from a usability standpoint in this case...

--
Ticket URL: <http://www.pkgcore.org/trac/pkgcore/ticket/172#comment:5>