[pkg-discuss] Code review request for build 164 resync

[david...@oracle.com]

I'd appreciate a review of the following webrev

http://cr.opensolaris.org/~comay/webrev-18152/

that includes fixes for the following issues

18152 add libproxy-gnome to slim_install
18164 Please add system/install/configuration package into 'slim_install' and 'server_install' clusters
18192 resync repository to snv_164
_______________________________________________
pkg-discuss mailing list
pkg-d...@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

[Danek Duvall]

david...@oracle.com wrote:

> http://cr.opensolaris.org/~comay/webrev-18152/

LGTM.

Danek

[Alan Coopersmith]

On 04/21/11 03:36 PM, david...@oracle.com wrote:
> I'd appreciate a review of the following webrev
>
> http://cr.opensolaris.org/~comay/webrev-18152/
>
> that includes fixes for the following issues
>
> 18152 add libproxy-gnome to slim_install
> 18164 Please add system/install/configuration package into 'slim_install' and
> 'server_install' clusters

https://defect.opensolaris.org/bz/show_bug.cgi?id=18165 also mentioned
auto_install, but that didn't get copied into 18164 when it was closed
as dup - should it be added there as well?

Everything else seemed fine to me.

--
-Alan Coopersmith- alan.coo...@oracle.com
Oracle Solaris Platform Engineering: X Window System

[david...@oracle.com]

> https://defect.opensolaris.org/bz/show_bug.cgi?id=18165 also mentioned
> auto_install, but that didn't get copied into 18164 when it was closed
> as dup - should it be added there as well?

Ethan has confirmed that it's just service_install & slim_install that
need the package (as part of post-installation system configuration.)

> Everything else seemed fine to me.

Thanks to you and Danek for the review.