[pkg-discuss] Code review request for build 153 resync

[david...@oracle.com]

I'd appreciate a review of the following webrev

http://cr.opensolaris.org/~comay/webrev-17365/

which covers the following

17365 Add pkg:/security/sudo to auto_install
17415 resync repository to snv_153

Thanks.
_______________________________________________
pkg-discuss mailing list
pkg-d...@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

[Alan Coopersmith]

david...@oracle.com wrote:
> I'd appreciate a review of the following webrev
>
> http://cr.opensolaris.org/~comay/webrev-17365/
>
> which covers the following
>
> 17365 Add pkg:/security/sudo to auto_install
> 17415 resync repository to snv_153

The X & xscreensaver changes look right to me. (I didn't see
anything wrong with the others, but don't know what changes went
into SFW, etal.)

--
-Alan Coopersmith- alan.coo...@oracle.com
Oracle Solaris Platform Engineering: X Window System

[Danek Duvall]

david...@oracle.com wrote:

> http://cr.opensolaris.org/~comay/webrev-17365/

You added "version 5.0" to both libxklavier and libgnomekbd. Have we
started versioning the gnome packages for them?

Otherwise, looks good.

Danek

[david...@oracle.com]

> You added "version 5.0" to both libxklavier and libgnomekbd. Have we
> started versioning the gnome packages for them?

I have done this although not consistently (and I tend to focus on
those packages whose upstream version is < 0.5.11). Since this
particular version number is > 0.5.11 and can always be "upgraded" to
5.0 later, I'm going to remove the explicit version here. JDS will be
moving to native IPS relatively soon and they'll adjust this then.

> Otherwise, looks good.

Thanks for the review.