Issue 30 in django-messages: Have templates display "No messages." if the message_list is empty.

4 views
Skip to first unread message

codesite...@google.com

unread,
Feb 14, 2009, 6:32:44 AM2/14/09
to pinax-...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 30 by rockmhoward: Have templates display "No messages." if the
message_list is empty.
http://code.google.com/p/django-messages/issues/detail?id=30

What steps will reproduce the problem?
1. Go to Inbox, Sent (i,e., outbox) or Trash
2. If the message_list is empty, an empty table is shown.

Unless the CSS has been improved to beautify the empty table case, the
resulting empty table is quite ugly which is a turn off for new users.
I would prefer to see a simple message like "No messages." instead.


The fix:
In each of inbox.html, outbox.html and trash.html:

On the line after the <h1>...</h1> and before the <table class="messages">,
insert:
{% if message_list %}

On the line after </table>, insert:
{% else %}
<p>No messages.</p>
{% endif %}

That will do it.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

codesite...@google.com

unread,
Feb 17, 2009, 12:27:42 AM2/17/09
to pinax-...@googlegroups.com
Updates:
Status: Accepted
Owner: a...@rcs4u.de
Labels: -Type-Defect Type-Enhancement

Comment #1 on issue 30 by a...@rcs4u.de: Have templates display "No

messages." if the message_list is empty.
http://code.google.com/p/django-messages/issues/detail?id=30

(No comment was entered for this change.)

codesite...@google.com

unread,
Oct 5, 2009, 3:41:43 AM10/5/09
to pinax-...@googlegroups.com
Updates:
Status: Fixed

Comment #2 on issue 30 by a...@rcs4u.de: Have templates display "No

messages." if the message_list is empty.
http://code.google.com/p/django-messages/issues/detail?id=30

fixed in r116.

Reply all
Reply to author
Forward
0 new messages