Problem using ET editor

[Steven Fellini]

I'm trying to follow some examples with the ET text editor.  The problem is with the TAB character when in text mode.

If the cursor is at column 1, typing TAB doesn't advance the cursor.  If I type any other character at column 0, then a subsequent TAB works as expected.

Same problem with Logitech or Raspberry keyboards.

Thanks for any help,

Steve.

[Angelo Papenhoff/aap]

Hm, i think you're right that my tab logic is not quite right. what user interface are you using? pdp1_periph, the web UI or perhaps even plain telnet?

[Angelo Papenhoff/aap]

just pushed a fix to my dev branch of the pidp1 repo. i think it's correct now, thanks for catching that!

[Steven Fellini]

Thank-you Angelo, that fixed it!

[Bill E]

I'm looking at merging the change into my repo, I see nothing has been updated in the main pidp-1 repo. Is this typewriter.c in pdp1_periph in aap's blincolnlights repo?

If so, I'm a bit hesitant. Things there are turning into a mish-mash of quite a few different computers, getting hard to sort out what will work with just the pdp-1 stream.

Is it safe to merge all of pdp1_periph? It's vastly different from the main pidp1 branch (and my branch).

Along these lines, I've cleaned all of the non PDP-1 impls out of my branch, I want it to be a PDP-1, not a large collection of various machines in various states.

I suppose I shouldn't be lazy and  just try it.

I've also reorganized pdp1.c in my repo to move the display IOT code out of the main emulator and into its own IOT where I think it belongs; the original system didn't have all the hardware in the PDP-1, it was an external peripheral. It cleans up pdp1.c a fair amount. The timing is preserved.

Bill

[Bill E]

Ok, finally found the correct file, git was not being cooperative. I've merged the fix, pdp1_periph/typewriter.c, into my repo.

Bill

[Win Heagy]

How would I go about picking up this 'tab' change?  I just noticed it today when using the GUI on the CIRCLE example...worked Ok for me on the web version.  I installed the PiDP-1 software about 2-3 weeks go, but it was not in the version I installed.

Thanks,

Win

[Bill E]

Angelo didn't add it to the pidp1 repo. It is in mine. You can pull just the file src/periph/typewriter.c from it, copy to your local pidp1 in the same-named dir, and reinstall.

Or, you can just use my repo entirely which has a lot more goodies. :)

https://github.com/wjenh/pidp1-mods.git

Bill

[Win Heagy]

Great, thanks.  I'll give it a try.

Win