Suggestion for opening PStyledText

[jles...@gmx.de]

Hi Piccolo team
I need support for dotted underline style in a text field and couldn't find an approriate way in PStyledText. But in fact it would be quite easy to add support for this in a derived class if PStyledText were a bit more open for derivation. I would appreciate if you considered to add the slight modifications for PStyledText from the attached version. It just makes some methods protected instead of private, separates a few code blocks in protected template methods, and adds getters to some of the inner classes.

Kind regards,
Jan
 

[Michael Heuer]

Hello Jan,

If you could create an issue here

https://code.google.com/p/piccolo2d/issues/list

and attach your changes as a patch (svn diff > patch.diff) I can review it and get it merged.

Thank you,

   michael

--
You received this message because you are subscribed to the Google Groups "Piccolo2D Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to piccolo2d-use...@googlegroups.com.
To post to this group, send email to piccolo...@googlegroups.com.
Visit this group at http://groups.google.com/group/piccolo2d-users.
For more options, visit https://groups.google.com/d/optout.

[jles...@gmx.de]

Hi Michael
OK, I will try. By the way, I found a little bug in PStyledText too. I will add an issue for this as well.

Regards,
Jan

[jles...@gmx.de]

OK, I made it. Please have a look at

    https://code.google.com/p/piccolo2d/issues/detail?id=261

for more openess of PStyledText for derivation and

    https://code.google.com/p/piccolo2d/issues/detail?id=260

For the bug and an attached fix for the problem of missplaced uderlines

Regards,
Jan