Issue 261 in piccolo2d: PStyledText too closed for extension in derivations

[picc...@googlecode.com]

Status: New
Owner: ----

New issue 261 by jless...@gmx.de: PStyledText too closed for extension in
derivations
https://code.google.com/p/piccolo2d/issues/detail?id=261

I needed support for dotted underlines in a PStyledText but wasn't able to
add appropriate functionality. In fact it would have been quite easy to add
the functionality in a derived class if PStyledText were a bit more open
for overrides in derivations.

Please consider the attached patch as an improvement. It does not change
the existing functionality but just opens it a bit by
- Making some methods protected instead of private
- Separating some code blocks in protected template methods
- Adding getters to inner classes
- Encapsulating the construction of SegmentInfo in a method to allow
derived classes providing an extended type instead


Attachments:
PStyledText.java.patch 5.5 KB

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[picc...@googlecode.com]

Updates:
Status: Accepted
Owner: heue...@gmail.com
Labels: Type-Enhancement Priority-High Effort-Medium OpSys-All
Toolkit-Piccolo2D.Java Component-Extras

Comment #1 on issue 261 by heue...@gmail.com: PStyledText too closed for

extension in derivations
https://code.google.com/p/piccolo2d/issues/detail?id=261

(No comment was entered for this change.)

[picc...@googlecode.com]

Updates:
Status: Fixed

Comment #3 on issue 261 by heue...@gmail.com: PStyledText too closed for

extension in derivations
https://code.google.com/p/piccolo2d/issues/detail?id=261

Patch applied in revision 1273, thanks!

Please review and if looks ok, mark as Status: Verified