PSR-17 Explicit Nullable

[Woody Gilk]

As editor of PSR-17, I hereby call a vote to:

1. Change the minimum required version of PHP to 7.1 for PSR-17.
   
2. Add explicit nullable types to PSR-17 interfaces.
3. Tag a new release v1.1.0 of psr/http-factory with changes (1) and (2).
   

The relevant PRs are:

https://github.com/php-fig/fig-standards/pull/1321
https://github.com/php-fig/http-factory/pull/17

Thank you,

--
Woody Gilk (he/him)
https://www.shadowhand.com

[Alessandro Lai]

To clarify, this is the same as an Errata vote: https://www.php-fig.org/bylaws/voting-protocol/#errata-vote, which follows the Approval Vote procedures of:
- only Core Committee members vote
- 50% quorum
- 2/3 majority required

[Matteo Beccati]

+1

thanks for the quick follow up!

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAGOJM6JNuwYA9Twh-0FJZ7sgQ_kaLCdBUSHMTRLXgb95TSox4Q%40mail.gmail.com.

--

--
Matteo Beccati

Development & Consulting - http://www.beccati.com/

[Ken Guest]

and it's a +1 from me :-)

[Vincent de Lau]

+1 from me as well.

I would not mind a small rationale in the errata why it is `?string` and not `string|null`.

[Matteo Beccati]

Hi Vincent,Il 15/04/2024 15:28, Vincent de Lau ha scritto:> I would not

mind a small rationale in the errata why it is `?string` and
> not `string|null`.

That would mean raising the required version to 8.0, when union types
were introduced.


Cheers

[Korvin Szanto]

+1

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/c57a495e-f641-4891-919d-ea86dae170e4n%40googlegroups.com.

[Woody Gilk]

On Mon, Apr 15, 2024 at 8:40 AM Matteo Beccati <mat...@beccati.com> wrote:

Hi Vincent,Il 15/04/2024 15:28, Vincent de Lau ha scritto:> I would not
mind a small rationale in the errata why it is `?string` and
> not `string|null`.

That would mean raising the required version to 8.0, when union types
were introduced.

Which we can do, but it would be a *major* (2.0) version change. This is an incremental step with a *minor* (1.1) version change.

--
Woody Gilk (he/him)
https://www.shadowhand.com

 

Cheers
--
Matteo Beccati

Development & Consulting - http://www.beccati.com/

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/723dba4f-ab7f-4dab-a63d-73951da3798d%40beccati.com.

[Alessandro Chitolina]

+1

Il giorno lunedì 15 aprile 2024 alle 16:00:50 UTC+2 Woody Gilk ha scritto:

On Mon, Apr 15, 2024 at 8:40 AM Matteo Beccati <mat...@beccati.com> wrote:

Hi Vincent,Il 15/04/2024 15:28, Vincent de Lau ha scritto:> I would not
mind a small rationale in the errata why it is `?string` and
> not `string|null`.

That would mean raising the required version to 8.0, when union types
were introduced.

Which we can do, but it would be a *major* (2.0) version change. This is an incremental step with a *minor* (1.1) version change.

It would be a minor change even if bumping to PHP 8+ and switching to "string|null" union type as long as "= null" is in place.

This change would not break any existing API as the implementations with "string $x = null" are still accepted even if the interface declares it as "string|null"

[Larry Garfield]

+1

(Please don't discuss in this thread, folks.)

--
Larry Garfield
la...@garfieldtech.com

On Mon, Apr 15, 2024, at 12:11 PM, Woody Gilk wrote:
> As editor of PSR-17, I hereby call a vote to:

> 1. Change the minimum required version of PHP to 7.1 for PSR-17.
> 2. Add explicit nullable types to PSR-17 interfaces.
> 3. Tag a new release v1.1.0 of psr/http-factory with changes (1) and (2).

> The relevant PRs are:
>
> https://github.com/php-fig/fig-standards/pull/1321
> https://github.com/php-fig/http-factory/pull/17
>
> Thank you,
>
> --
> Woody Gilk (he/him)
> https://www.shadowhand.com
>

> --
> You received this message because you are subscribed to the Google
> Groups "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to php-fig+u...@googlegroups.com.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/php-fig/CAGOJM6JNuwYA9Twh-0FJZ7sgQ_kaLCdBUSHMTRLXgb95TSox4Q%40mail.gmail.com
> <https://groups.google.com/d/msgid/php-fig/CAGOJM6JNuwYA9Twh-0FJZ7sgQ_kaLCdBUSHMTRLXgb95TSox4Q%40mail.gmail.com?utm_medium=email&utm_source=footer>.

[Chuck Burgess]

+1

CRB

--

You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAGOJM6JNuwYA9Twh-0FJZ7sgQ_kaLCdBUSHMTRLXgb95TSox4Q%40mail.gmail.com.

[Jaap van Otterdijk]

+1

Jaapio

Op maandag 15 april 2024 om 17:27:29 UTC+2 schreef Chuck Burgess:

[Cees-Jan Kiewiet]

+1

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/78f9d917-b3c1-454f-bf59-8f6e01df58aan%40googlegroups.com.

--

Website | Blog | Github | Linkedin | Twitter

[Navarr Barnier]

+1

[Mark Niebergall]

Voting is closed:

- Voting passed, with 10 yes votes

- Quorum of at least 50% was reached (10/12 voted or 83%)

Alessandro please re-review https://github.com/php-fig/fig-standards/pull/1321, which has your Changes Requested for a vote, which is now completed. After that we can get the PR merged.

Thank you all for voting and contributing.

Mark Niebergall

[Alessandro Lai]

I merged the PR, tagged the library, updated the site, and tooted/tweeted about it.