[PSR-19] deprecate double closing brace on inline internal tag

50 views
Skip to first unread message

Chuck Burgess

unread,
Oct 15, 2018, 3:59:07 PM10/15/18
to PHP Framework Interoperability Group
Following historical precedence from phpDocumentor 1.x, the inline `@internal` tag used an unusual syntax:

`{@internal}}`  (note the double closing braces)

From the 1.x manual:

Unlike other inline tags, {@internal}} may contain other inline tags due to its purpose. To terminate an {@internal}} inline tag, you must use two ending brackets "}}"

I can only assume this need had something to do with the state of parsers back then.

When PSR-5 was first drafted, this syntax drew ire from many due to how IDEs would treat it as an unbalanced brace.

I have issued a pull request (https://github.com/php-fig/fig-standards/pull/1100) that seeks to remove this behavior, while at least acknowledging its existence in the past.  I'm now asking for feedback on this proposed change.

Please discuss this draft change here on this mailing list thread, rather than on the PR.
CRB

Chuck Burgess

unread,
Nov 8, 2018, 1:25:41 PM11/8/18
to PHP Framework Interoperability Group
Given the approvals on the PR, I've merged it and will consider this thread closed.
CRB
Reply all
Reply to author
Forward
0 new messages