Feature Request

80 views
Skip to first unread message

Adz

unread,
Oct 20, 2022, 9:07:45 AM10/20/22
to phoenix-core
Hello,

Often when testing I'll add data-test attributes to the HTML that I can assert on in tests - either using Floki or with `=~`.

They allow me to decouple a bit from markup changes and avoid things like "the order of html attributes changed and now all my tests fail".

It would be great if I could purge those attributes for production though, would this be something Phoenix could add? (I'm happy to attempt work on it).

There are tradeoffs of course but I thought I'd kick off the discussion.

Best

Adam

Chris McCord

unread,
Oct 20, 2022, 9:23:25 AM10/20/22
to phoenix-core
I’m not convinced this is necessary. I would provide a DOM id to the elements and use that in your test. If you need to identify an element in the markup, then the the standard way for clients to query those is via an ID. LiveViewTest is a client of the app just like the browser is. Thanks!

tboly kyle

unread,
Dec 29, 2022, 3:22:37 AM12/29/22
to phoenix-core
CONTACT DETAILS

WICKR APP......infobudsman

PHONE CALL.....+1(669)2570640

SIGNAL.....+1(669)2570640

EMAIL.....benrodger83@gmail.com

i have ketamine vials pharmacy grade for both human and animals,ketamine crystals pure cooked out of the original vials(uncut)i do supply on daily basis and i accept bulk and smaller orders.i have my feedback and i provide dated pictures and video of stock

please i am not interested in replying time waster as i got no time for them..

i do other product like weed,painpills..i ship and deliver worldwide securely

interested client ready to do real and big business should not hesitate to massage me using any of my contact details bellow i am online 24hours to take orders


CONTACT DETAILS

WICKR APP......infobudsman

PHONE CALL.....+1(669)2570640

SIGNAL.....+1(669)2570640

EMAIL.....benrodger83@gmail.com
Reply all
Reply to author
Forward
0 new messages