[krishnprakash/codeql] 20fea3: Python: Remove points-to from `Metrics.qll`

0 views
Skip to first unread message

Phileco

unread,
Feb 24, 2026, 6:48:10 PM (9 days ago) Feb 24
to philecodi...@googlegroups.com
Branch: refs/heads/main
Home: https://github.com/krishnprakash/codeql
Commit: 20fea3955ebac8b8e2de3f5613322e916f813811
https://github.com/krishnprakash/codeql/commit/20fea3955ebac8b8e2de3f5613322e916f813811
Author: Taus <tau...@github.com>
Date: 2026-02-19 (Thu, 19 Feb 2026)

Changed paths:
M python/ql/lib/LegacyPointsTo.qll
M python/ql/lib/python.qll
M python/ql/lib/semmle/python/Metrics.qll

Log Message:
-----------
Python: Remove points-to from `Metrics.qll`

Moves the classes/predicates that _actually_ depend on points-to to the
`LegacyPointsTo` module, leaving behind a module that contains all of
the metrics-related stuff (line counts, nesting depth, etc.) that don't
need points-to to be evaluated.

Consequently, `Metrics` is now no longer a private import in
`python.qll`.


Commit: e8de8433f4a8493ffb50292f2d7f4ffd0cb7e258
https://github.com/krishnprakash/codeql/commit/e8de8433f4a8493ffb50292f2d7f4ffd0cb7e258
Author: Taus <tau...@github.com>
Date: 2026-02-19 (Thu, 19 Feb 2026)

Changed paths:
M python/ql/src/Functions/OverlyComplexDelMethod.ql
M python/ql/src/Metrics/CLinesOfCode.ql
M python/ql/src/Metrics/ClassAfferentCoupling.ql
M python/ql/src/Metrics/ClassEfferentCoupling.ql
M python/ql/src/Metrics/CommentRatio.ql
M python/ql/src/Metrics/CyclomaticComplexity.ql
M python/ql/src/Metrics/DocStringRatio.ql
M python/ql/src/Metrics/FLines.ql
M python/ql/src/Metrics/FLinesOfCode.ql
M python/ql/src/Metrics/FLinesOfComments.ql
M python/ql/src/Metrics/FunctionNumberOfCalls.ql
M python/ql/src/Metrics/FunctionStatementNestingDepth.ql
M python/ql/src/Metrics/History/HChurn.ql
M python/ql/src/Metrics/History/HLinesAdded.ql
M python/ql/src/Metrics/History/HLinesDeleted.ql
M python/ql/src/Metrics/History/HNumberOfAuthors.ql
M python/ql/src/Metrics/History/HNumberOfCoCommits.ql
M python/ql/src/Metrics/History/HNumberOfReCommits.ql
M python/ql/src/Metrics/History/HNumberOfRecentAuthors.ql
M python/ql/src/Metrics/History/HNumberOfRecentChangedFiles.ql
M python/ql/src/Metrics/LackofCohesionInMethodsCK.ql
M python/ql/src/Metrics/LackofCohesionInMethodsHM.ql
M python/ql/src/Metrics/ModuleAfferentCoupling.ql
M python/ql/src/Metrics/ModuleEfferentCoupling.ql
M python/ql/src/Metrics/NumberOfParametersWithoutDefault.ql
M python/ql/src/Summary/LinesOfCode.ql
M python/ql/src/Summary/LinesOfUserCode.ql
M python/ql/test/library-tests/ControlFlow/general/Cyclo.ql

Log Message:
-----------
Python: Update all metrics-dependant queries

The ones that no longer require points-to no longer import
`LegacyPointsTo`. The ones that do use the specific
`...MetricsWithPointsTo` classes that are applicable.


Commit: 07099f17d670859846e59b9ecb83d948fe6f5754
https://github.com/krishnprakash/codeql/commit/07099f17d670859846e59b9ecb83d948fe6f5754
Author: Taus <tau...@github.com>
Date: 2026-02-19 (Thu, 19 Feb 2026)

Changed paths:
A python/ql/lib/change-notes/2026-02-18-remove-points-to-from-metrics.md

Log Message:
-----------
Python: Add change note


Commit: 15af6c1b20ebbb3b4016e11e6e7e9af9ec626f45
https://github.com/krishnprakash/codeql/commit/15af6c1b20ebbb3b4016e11e6e7e9af9ec626f45
Author: Mathias Vorreiter Pedersen <map...@microsoft.com>
Date: 2026-02-24 (Tue, 24 Feb 2026)

Changed paths:
M cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll

Log Message:
-----------
C++: Provide barrier node API without the unit column when instantiating non-parameterized barrier guards.


Commit: d36350aca49240e9c90a9557492c4aa546310800
https://github.com/krishnprakash/codeql/commit/d36350aca49240e9c90a9557492c4aa546310800
Author: Mathias Vorreiter Pedersen <math...@github.com>
Date: 2026-02-24 (Tue, 24 Feb 2026)

Changed paths:
A cpp/ql/lib/change-notes/2026-02-24-barrier-guards.md

Log Message:
-----------
C++: Add change note.


Commit: ea9e4b34092ada6b60b5f506df8511e94cff2746
https://github.com/krishnprakash/codeql/commit/ea9e4b34092ada6b60b5f506df8511e94cff2746
Author: Mathias Vorreiter Pedersen <math...@github.com>
Date: 2026-02-24 (Tue, 24 Feb 2026)

Changed paths:
M cpp/ql/test/library-tests/dataflow/ir-barrier-guards/test.ql

Log Message:
-----------
C++: Make a test slightly more verbose to catch this issue in the future.


Commit: f107235db2038b95393d8030807560650849d5a8
https://github.com/krishnprakash/codeql/commit/f107235db2038b95393d8030807560650849d5a8
Author: Taus <tau...@github.com>
Date: 2026-02-24 (Tue, 24 Feb 2026)

Changed paths:
M python/ql/lib/change-notes/2026-02-18-remove-points-to-from-metrics.md

Log Message:
-----------
Update change note


Commit: 6bfb1e1faeb8b7b07170eaefb4a2108e899a709a
https://github.com/krishnprakash/codeql/commit/6bfb1e1faeb8b7b07170eaefb4a2108e899a709a
Author: Taus <tau...@github.com>
Date: 2026-02-24 (Tue, 24 Feb 2026)

Changed paths:
M python/ql/lib/LegacyPointsTo.qll
A python/ql/lib/change-notes/2026-02-18-remove-points-to-from-metrics.md
M python/ql/lib/python.qll
M python/ql/lib/semmle/python/Metrics.qll
M python/ql/src/Functions/OverlyComplexDelMethod.ql
M python/ql/src/Metrics/CLinesOfCode.ql
M python/ql/src/Metrics/ClassAfferentCoupling.ql
M python/ql/src/Metrics/ClassEfferentCoupling.ql
M python/ql/src/Metrics/CommentRatio.ql
M python/ql/src/Metrics/CyclomaticComplexity.ql
M python/ql/src/Metrics/DocStringRatio.ql
M python/ql/src/Metrics/FLines.ql
M python/ql/src/Metrics/FLinesOfCode.ql
M python/ql/src/Metrics/FLinesOfComments.ql
M python/ql/src/Metrics/FunctionNumberOfCalls.ql
M python/ql/src/Metrics/FunctionStatementNestingDepth.ql
M python/ql/src/Metrics/History/HChurn.ql
M python/ql/src/Metrics/History/HLinesAdded.ql
M python/ql/src/Metrics/History/HLinesDeleted.ql
M python/ql/src/Metrics/History/HNumberOfAuthors.ql
M python/ql/src/Metrics/History/HNumberOfCoCommits.ql
M python/ql/src/Metrics/History/HNumberOfReCommits.ql
M python/ql/src/Metrics/History/HNumberOfRecentAuthors.ql
M python/ql/src/Metrics/History/HNumberOfRecentChangedFiles.ql
M python/ql/src/Metrics/LackofCohesionInMethodsCK.ql
M python/ql/src/Metrics/LackofCohesionInMethodsHM.ql
M python/ql/src/Metrics/ModuleAfferentCoupling.ql
M python/ql/src/Metrics/ModuleEfferentCoupling.ql
M python/ql/src/Metrics/NumberOfParametersWithoutDefault.ql
M python/ql/src/Summary/LinesOfCode.ql
M python/ql/src/Summary/LinesOfUserCode.ql
M python/ql/test/library-tests/ControlFlow/general/Cyclo.ql

Log Message:
-----------
Merge pull request #21344 from github/tausbn/python-remove-points-to-from-metrics-libraries

Python: Remove points-to from metrics library


Commit: 266130b5cf40ad1e651fd1f9b528c00da492e349
https://github.com/krishnprakash/codeql/commit/266130b5cf40ad1e651fd1f9b528c00da492e349
Author: Mathias Vorreiter Pedersen <math...@github.com>
Date: 2026-02-24 (Tue, 24 Feb 2026)

Changed paths:
A cpp/ql/lib/change-notes/2026-02-24-barrier-guards.md
M cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
M cpp/ql/test/library-tests/dataflow/ir-barrier-guards/test.ql

Log Message:
-----------
Merge pull request #21360 from microsoft/unbreak-changes

C++: Provide `BarrierGuard` API without a `Unit` column when instantiating non-parameterized `BarrierGuard`s


Commit: ab66b0d27d9d1cf55518e0030f420883995e9f44
https://github.com/krishnprakash/codeql/commit/ab66b0d27d9d1cf55518e0030f420883995e9f44
Author: Phileco <132178579+k...@users.noreply.github.com>
Date: 2026-02-25 (Wed, 25 Feb 2026)

Changed paths:
A cpp/ql/lib/change-notes/2026-02-24-barrier-guards.md
M cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
M cpp/ql/test/library-tests/dataflow/ir-barrier-guards/test.ql
M python/ql/lib/LegacyPointsTo.qll
A python/ql/lib/change-notes/2026-02-18-remove-points-to-from-metrics.md
M python/ql/lib/python.qll
M python/ql/lib/semmle/python/Metrics.qll
M python/ql/src/Functions/OverlyComplexDelMethod.ql
M python/ql/src/Metrics/CLinesOfCode.ql
M python/ql/src/Metrics/ClassAfferentCoupling.ql
M python/ql/src/Metrics/ClassEfferentCoupling.ql
M python/ql/src/Metrics/CommentRatio.ql
M python/ql/src/Metrics/CyclomaticComplexity.ql
M python/ql/src/Metrics/DocStringRatio.ql
M python/ql/src/Metrics/FLines.ql
M python/ql/src/Metrics/FLinesOfCode.ql
M python/ql/src/Metrics/FLinesOfComments.ql
M python/ql/src/Metrics/FunctionNumberOfCalls.ql
M python/ql/src/Metrics/FunctionStatementNestingDepth.ql
M python/ql/src/Metrics/History/HChurn.ql
M python/ql/src/Metrics/History/HLinesAdded.ql
M python/ql/src/Metrics/History/HLinesDeleted.ql
M python/ql/src/Metrics/History/HNumberOfAuthors.ql
M python/ql/src/Metrics/History/HNumberOfCoCommits.ql
M python/ql/src/Metrics/History/HNumberOfReCommits.ql
M python/ql/src/Metrics/History/HNumberOfRecentAuthors.ql
M python/ql/src/Metrics/History/HNumberOfRecentChangedFiles.ql
M python/ql/src/Metrics/LackofCohesionInMethodsCK.ql
M python/ql/src/Metrics/LackofCohesionInMethodsHM.ql
M python/ql/src/Metrics/ModuleAfferentCoupling.ql
M python/ql/src/Metrics/ModuleEfferentCoupling.ql
M python/ql/src/Metrics/NumberOfParametersWithoutDefault.ql
M python/ql/src/Summary/LinesOfCode.ql
M python/ql/src/Summary/LinesOfUserCode.ql
M python/ql/test/library-tests/ControlFlow/general/Cyclo.ql

Log Message:
-----------
Merge branch 'github:main' into main


Compare: https://github.com/krishnprakash/codeql/compare/3ca4d4cbaf39...ab66b0d27d9d

To unsubscribe from these emails, change your notification settings at https://github.com/krishnprakash/codeql/settings/notifications
Reply all
Reply to author
Forward
0 new messages