[Pharo-project] Split sound package -> Cog not loading in last 1.4

3 views
Skip to first unread message

Mariano Martinez Peck

unread,
Jan 24, 2012, 2:12:14 PM1/24/12
to Pharo Development, Squeak Development Discussion Virtual Machine
Hi guys. Cog is not loading anymore in 1.4 because of some classes depending on Project from the 'Sound' package found in PharoSound repo in SS. At the beginning I thought to create a separate package "SoundVMSupport" and put there the needed classes, but I discover that there are a lot which are needed. And moreover, all of those needed classes are in the category Sound-Synthesis. The classes problematic (regarding Project and morphs) are in the other package Sound-Scores. I have just tried and split the Sound package in two: SoundScores and SoundSynthesis. Then I changed ConfigurationOfCog to load SoundSynthesis rather than Sound. That works and I can now build the VM without problems.

I think that the split makes sense even without of the need of Cog. Do you agree?  If true, I can commit everything.
One of the things I am not sure is how to make sure Sound package is not used anymore. All I can do is:

a) Put a comment in squeaksource page saying that the packages are now SoundScores and SoundSynthesis.
b) Create a new baseline and version of ConfigurationOfPharoSound which reflecs this change
c) Commit a version of everything empty (no single class) to the package Sound.

Which ones of these should I do ?

Thanks

--
Mariano
http://marianopeck.wordpress.com

Henrik Johansen

unread,
Jan 24, 2012, 4:07:09 PM1/24/12
to Squeak Virtual Machine Development Discussion, Pharo Development


My 2c: Just split of Sound-Scores into a separate package, leaving Sound containing Sound-Synthesis.
Other than that, it sounds like a good plan.

Why? Because it:
1. Makes it easy to still synch with the version in Squeak.
2. Avoids having to create a new baseline.
3. The extra work of either a), b), or c) is unnecessary.

Cheers,
Henry

Mariano Martinez Peck

unread,
Jan 25, 2012, 6:21:45 AM1/25/12
to Squeak Virtual Machine Development Discussion, Pharo Development

Good idea. I have just do that. And I have created a new baseline/version if ConfigurationOfPharo sound so that to include SoundScores....
But Cog still uses Sound, so now it is working :)


 
Cheers,
Henry



--
Mariano
http://marianopeck.wordpress.com

Reply all
Reply to author
Forward
0 new messages