Re: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)

[Dave Page]

Hi

On Fri, Mar 1, 2013 at 11:46 AM, Dhiraj Chawla
<dhiraj...@enterprisedb.com> wrote:
> Hi Dave,
>
> Attached is the patch that fixes the issue where if a user connects to
> a server, and then tries to add an entry to pg_hba.conf via
> pgHbaConfig form dialog and the newly added entry does not get saved.
>
> Actually a member variable 'isComment' in the pgHbaConfigLine class
> was not initialized. This class stores data of each line of the
> pg_hba.conf file. On some system the default value was set to true
> while on others it was getting set to false. But for empty lines if it
> is set to true, the other logic in pgHbaConfig form dialogs works as
> expected and the newly added entry is getting saved properly.
>
> Let me know your feedback on the same.

Thanks - works for me! Patch committed.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin...@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[Dhiraj Chawla]

Thanks Dave..

On Fri, Mar 1, 2013 at 10:59 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hi
>
> On Fri, Mar 1, 2013 at 11:46 AM, Dhiraj Chawla
> <dhiraj...@enterprisedb.com> wrote:
>> Hi Dave,
>>
>> Attached is the patch that fixes the issue where if a user connects to
>> a server, and then tries to add an entry to pg_hba.conf via
>> pgHbaConfig form dialog and the newly added entry does not get saved.
>>
>> Actually a member variable 'isComment' in the pgHbaConfigLine class
>> was not initialized. This class stores data of each line of the
>> pg_hba.conf file. On some system the default value was set to true
>> while on others it was getting set to false. But for empty lines if it
>> is set to true, the other logic in pgHbaConfig form dialogs works as
>> expected and the newly added entry is getting saved properly.
>>
>> Let me know your feedback on the same.
>
> Thanks - works for me! Patch committed.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--

regards,

Dhiraj Chawla
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522