Regression Tests

[Jens Eckel]

Dear all,

before a pull request for my changes to the code to include anisotropic tortuosities, I tried to run the regression tests (code compiled with -O0, OS Ubuntu 22.04 LTS). Even for the master branch without my modifications, not all of the tests pass (pflotran-tests_petsc_new_O3_master_without_aniso.testlog). For the case including my modifications, the same errors occur (pflotrantests_petsc_new_O3_master_with_aniso.testlog), so these modifications are not the reason for the test failures observed.

Thanks in advance

Jens

[Hammond, Glenn E]

Jens,

 

Please push the changes to your fork and submit a pull request. I will then create a branch for your changes in the main repository, and we can see which test fail in the cloud and work from there…much easier.

 

Regards,

Glenn

 

From: pflotr...@googlegroups.com <pflotr...@googlegroups.com> On Behalf Of Jens Eckel
Sent: Thursday, December 14, 2023 2:53 AM
To: pflotran-dev <pflotr...@googlegroups.com>
Subject: [pflotran-dev: 6221] Regression Tests

 

Check twice before you click! This email originated from outside PNNL.

 

--
You received this message because you are subscribed to the Google Groups "pflotran-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pflotran-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pflotran-dev/e0afb2dd-0574-4c08-83fc-3eaf6eaa4c6fn%40googlegroups.com.

[Jens Eckel]

Hi Glenn,

a pull request has been created, I will push my regression tests if the problems are solved.

I noticed that my own test cases crash with the changes from the master branch (version used before from end of September). If I include the OBSERVATION_FILE Block in the attachment, the code crashes. The same occurs e.g. for the regression test calcite-kinetics.in: If the OUTPUT block is commented out, there is no crash.

Best, Jens 

[Hammond, Glenn E]

Jens,

 

Do you expect the tortuosity to change over time (e.g., will it be calculated as a function of other state variables that change over time)?

 

field%tort_xx, etc. are only necessary if we need to store the initial value of the parameter. The storage of the initial permeability (field%perm0_xx) and porosity (field%porosity0) is necessary for other constitutive relations in the code where both can change over time (e.g., https://documentation.pflotran.org/theory_guide/mode_reactive_transport.html#changes-in-material-properties).

 

Thanks,

 

Glenn

 

To view this discussion on the web visit https://groups.google.com/d/msgid/pflotran-dev/038219d5-9862-4b25-92bd-e5e1f429ab14n%40googlegroups.com.

[Jens Eckel]

Hi Glenn,

at the moment tortuosity is not expected to change over time, but maybe eq. 32 can also be applied for the anisotropic case.
I tried to follow the implementation of the anisotropic permeabilities and keep the implementation as general as possible to have all possibilities in the future.

Best, Jens