Issue 147 in perlwikipedia: set_highlimits doesn't actually do anything - remove it

1 view
Skip to first unread message

perlwi...@googlecode.com

unread,
Mar 26, 2011, 9:08:35 PM3/26/11
to perlwiki...@googlegroups.com
Status: Accepted
Owner: mike.lifeguard
Labels: Type-Defect Priority-Medium

New issue 147 by mike.lifeguard: set_highlimits doesn't actually do
anything - remove it
http://code.google.com/p/perlwikipedia/issues/detail?id=147

The apihighlimits userright allows an account to retrieve more results at
once than normal. We have a set_highlimits method that sets an internal
flag - but that flag isn't used anywhere. I believe it was used in the past
to decide how many results to request from the API, but most methods
currently ask for 'max', which means we don't need to know whether we have
apihighlimits, or whether set_highlimits was used. There is no conceivable
reason not to use highlimits if you have the userright, and we do so by
default (by virtue of using 'max').

Because it is not used currently, will not be used in the future, and
causes confusion for programmers (see
https://rt.cpan.org/Ticket/Display.html?id=66790#txn-912990), I suggest
removing this method and the internal flag entirely.

perlwi...@googlecode.com

unread,
Mar 26, 2011, 9:28:42 PM3/26/11
to perlwiki...@googlegroups.com
Updates:
Status: Started

Comment #1 on issue 147 by mike.lifeguard: set_highlimits doesn't actually

Deprecated in r489. Will be removed in a future release.

perlwi...@googlecode.com

unread,
Jun 4, 2011, 12:56:19 PM6/4/11
to perlwiki...@googlegroups.com
Updates:
Status: Fixed

Comment #2 on issue 147 by mike.lifeguard: set_highlimits doesn't actually

This issue was closed by revision r513.

Reply all
Reply to author
Forward
0 new messages