[PATCH] Call backend_response_received hook after reproxy

9 views
Skip to first unread message

Adam Thomason

unread,
Sep 21, 2011, 2:34:52 AM9/21/11
to per...@googlegroups.com
Hi all,
I have a need to hook into Perlbal at the point where response headers have been received from a reproxied request. Currently the backend_response_received hook is only triggered when the headers are back from the initial response, not the reproxied one. Commit [1] patches Perlbal::ClientProxy to call the hook in the latter case. Conceivably this could be a problem for existing users of that hook which are not expecting to be triggered by the reproxied case. Does anyone know of such a use case in the wild? If so, a new hook could be added instead.
Thanks,
Adam

[1] https://github.com/athomason/Perlbal/commit/1e935ee63189c91892f19ed024f39bf9a9b6b9cd

dormando

unread,
Sep 21, 2011, 4:15:16 AM9/21/11
to per...@googlegroups.com

Pains me deep in the regret center to change hook behavior. :( Odds are
it's in someone's proprietary extension. I've only done similar if the
previous feature was outright broken.

Adam Thomason

unread,
Sep 21, 2011, 5:24:28 PM9/21/11
to per...@googlegroups.com
On Wed, Sep 21, 2011 at 1:15 AM, dormando <dorm...@rydia.net> wrote:

Pains me deep in the regret center to change hook behavior. :( Odds are
it's in someone's proprietary extension. I've only done similar if the
previous feature was outright broken.

That's understandable, I'm fine using a different hook name, e.g. "reproxy_response_received". Do you have any objection to that? If not I'll change my patch and update the docs to include it.

Adam

dormando

unread,
Sep 21, 2011, 5:32:26 PM9/21/11
to per...@googlegroups.com

Unless someone else speaks up, go nuts.

Adam Thomason

unread,
Sep 22, 2011, 1:59:35 PM9/22/11
to per...@googlegroups.com
On Wed, Sep 21, 2011 at 2:32 PM, dormando <dorm...@rydia.net> wrote:

> That's understandable, I'm fine using a different hook name, e.g. "reproxy_response_received". Do you have any objection to that? If not I'll change
> my patch and update the docs to include it.

Unless someone else speaks up, go nuts.
Gone nuts: https://github.com/athomason/Perlbal/commit/66bb7c4a0de8f6df42c134c1375870deefe2e6e6

dormando

unread,
Feb 1, 2012, 2:16:54 AM2/1/12
to per...@googlegroups.com

*cough*, pushed. :p

Reply all
Reply to author
Forward
0 new messages