Re: [perlbal] athomason, r785: add headers_list method

[Brad Fitzpatrick]

Where was the commit that added this to the XS version?

On Mon, Aug 4, 2008 at 1:43 PM, <com...@code.sixapart.com> wrote:

add headers_list method

U   trunk/lib/Perlbal/HTTPHeaders.pm
U   trunk/t/12-headers.t


Modified: trunk/lib/Perlbal/HTTPHeaders.pm
===================================================================
--- trunk/lib/Perlbal/HTTPHeaders.pm    2008-07-10 10:05:26 UTC (rev 784)
+++ trunk/lib/Perlbal/HTTPHeaders.pm    2008-08-04 20:43:08 UTC (rev 785)
@@ -265,6 +265,11 @@
    return $self->{headers}{$key} = shift;
 }

+sub headers_list {
+    my Perlbal::HTTPHeaders $self = shift;
+    return [$self->{headers} ? keys %{ $self->{headers} } : ()];
+}
+
 sub to_string_ref {
    my Perlbal::HTTPHeaders $self = shift;
    my $st = join("\r\n",

Modified: trunk/t/12-headers.t
===================================================================
--- trunk/t/12-headers.t        2008-07-10 10:05:26 UTC (rev 784)
+++ trunk/t/12-headers.t        2008-08-04 20:43:08 UTC (rev 785)
@@ -6,7 +6,7 @@

 use Perlbal;
 use Perlbal::HTTPHeaders;
-eval "use Perlbal::XS::HTTPHeaders;";
+eval "use Perlbal::XS::HTTPHeaders 0.20;";

 # classes we will be testing
 my @classes = ('Perlbal::HTTPHeaders');
@@ -33,6 +33,8 @@
    is($obj->header('header'), 'content', "headers without content 2 - $class");
    is($obj->header('anoTHER'), '', "headers without content 3 - $class");
    is($obj->header('notthere'), undef, "headers without content 4 - $class");
+
+    is_deeply([sort @{ $obj->headers_list }], [qw/ another header something /], 'headers_list');
 }

 1;