I'll be looking after 2007-11-i

0 views
Skip to first unread message

eddy...@gmail.com

unread,
Sep 23, 2008, 1:58:03 AM9/23/08
to perl58...@googlegroups.com
Heya folks,

I'd love to try to take a look at 2007-11-i.


Cheers,
Eddy


--

Paul Fenwick

unread,
Sep 23, 2008, 2:39:34 AM9/23/08
to perl58...@googlegroups.com
G'day Eddy,

eddy...@gmail.com wrote:

> I'd love to try to take a look at 2007-11-i.

You are awesome! Thank-you! 2007-11-i is yours!

If you want to push changes to github, you'll need to let me know your
username there. Otherwise patches to the list work a treat!

Volunteers.txt updated and pushed on master.

Cheerios,

Paul

--
Paul Fenwick <p...@perltraining.com.au> | http://perltraining.com.au/
Director of Training | Ph: +61 3 9354 6001
Perl Training Australia | Fax: +61 3 9354 2681

est

unread,
Sep 23, 2008, 2:46:50 AM9/23/08
to The Perl 5.8.9 delta project
Hi Paul,

On Sep 23, 4:39 pm, Paul Fenwick <p...@perltraining.com.au> wrote:
> If you want to push changes to github, you'll need to let me know your
> username there.  Otherwise patches to the list work a treat!

Never used git before but I'm happy to get my feet wet on it...
My username is "eddy".


Cheers,
Eddy

Paul Fenwick

unread,
Sep 23, 2008, 2:51:44 AM9/23/08
to perl58...@googlegroups.com
est wrote:

> Never used git before but I'm happy to get my feet wet on it...
> My username is "eddy".

You have a commit-bit! If for any reason git seems too tough, then you can
always use whatever you prefer locally, and just send me patches.

Cheerio,

est

unread,
Sep 23, 2008, 10:23:19 PM9/23/08
to The Perl 5.8.9 delta project
Hi folks,

Just need an opinion about the changes in:

[ 32257] By: nicholas on 2007/11/09 22:01:27
Log: Integrate:
[ 31456]
PerlFAQ sync.

[ 31559]
FAQ sync
Branch: maint-5.8/perl
!> pod/perlfaq.pod pod/perlfaq1.pod pod/perlfaq2.pod
!> pod/perlfaq4.pod pod/perlfaq5.pod pod/perlfaq7.pod
!> pod/perlfaq8.pod

It seems to me that all those changes are just about text alignment or
substituting perl{4,56} to Perl {4,5,6} - am I right in thinking that
this kind of changes do not need to go the delta pod and can be just
removed from my chunk straight?

Ta,
Eddy

Paul Fenwick

unread,
Sep 23, 2008, 10:54:16 PM9/23/08
to perl58...@googlegroups.com
G'day Eddy,

est wrote:

> [ 32257] By: nicholas on 2007/11/09 22:01:27

> [ 31456]
> [ 31559]

The Perl FAQs are actually maintained separately from the Perl core, and on
an irregular basis they get pushed back into the core repository.

> It seems to me that all those changes are just about text alignment or
> substituting perl{4,56} to Perl {4,5,6} - am I right in thinking that
> this kind of changes do not need to go the delta pod and can be just
> removed from my chunk straight?

Looking over the changes reveals a number of things which are simple
formatting fixes, but I've noticed there are some expanded questions. Just
looking at 31456 at:

http://public.activestate.com/cgi-bin/perlbrowse/p/31456

I can see there's a new answer on configuring the CPAN shell to always place
code in your private directory, and a small rewrite on manipulating @INC.

While these are not particularly newsworthy, I'd make a one-liner under "New
Documentation"

The Perl FAQs (F<perlfaq1>..F<perlfaq9>) have been updated.

A lot of people seem to forget that Perl even comes with a rather extensive
set of FAQs, so I don't mind them getting a one-line reminder. ;)

est

unread,
Sep 23, 2008, 11:11:05 PM9/23/08
to The Perl 5.8.9 delta project
Hey there Paul,

On Sep 24, 12:54 pm, Paul Fenwick <p...@perltraining.com.au> wrote:
> The Perl FAQs are actually maintained separately from the Perl core, and on
> an irregular basis they get pushed back into the core repository.

Ahhh ok...

> Looking over the changes reveals a number of things which are simple
> formatting fixes, but I've noticed there are some expanded questions. Just
> looking at 31456 at:
[snip]

> I can see there's a new answer on configuring the CPAN shell to always place
> code in your private directory, and a small rewrite on manipulating @INC.
> While these are not particularly newsworthy, I'd make a one-liner under "New
> Documentation"
[snip]

> A lot of people seem to forget that Perl even comes with a rather extensive
> set of FAQs, so I don't mind them getting a one-line reminder. ;)

Excellent - I'll put that in then...


Cheers,
Eddy


Eddy S.Tan

unread,
Sep 24, 2008, 11:12:55 AM9/24/08
to The Perl 5.8.9 delta project
Hi folks,

I just pushed a half-way done of my branch to the repository.
Would be really great if someone could check that all those changes look sane before me going forward...

Ta,
 Eddy

Paul Fenwick

unread,
Sep 24, 2008, 9:08:29 PM9/24/08
to perl58...@googlegroups.com
G'day Eddy,

Eddy S.Tan wrote:

I would rate the changes as "awesomely brilliant". Yes, please continue
like this!

I'm also *very* happy to see /k going into Perl 5.8.9. From Eddy's
excellent summary:

Regular expression introduces C</k> modifier for matching along with
new perl variables C<${^PREMATCH}>, C<${^MATCH}>, C<${^POSTMATCH}>
which are equivalent to C<$`>, C<$&> and C<$'>, B<except> that they
are only guaranteed to be defined after a successful match that was
executed with the C</k> (keep-copy) modifier. The use of these
variables incurs no global performance penalty, unlike their
punctuation char equivalents (#32263).

All the very best,

Eddy S.Tan

unread,
Sep 30, 2008, 8:57:56 AM9/30/08
to perl58...@googlegroups.com
Heya folks,

I've finished working on 2007-11-i. All changes are already pushed up to the branch...
I'm unsure about a few items which are added to TODO file in branch 2007-11-i.

Please note that the file 2007-11-i.txt in my branch is now empty as I cleared them up when working on the list.


Cheers,
 Eddy


eddy...@gmail.com

unread,
Sep 30, 2008, 11:29:43 PM9/30/08
to perl58...@googlegroups.com

Hey folks,


Btw, I should have mentioned that when pushing changes to my branch I didn't
do:
git pull
git merge master

Hopefully it won't cause any havoc.


Cheers,
Eddu

Paul Fenwick

unread,
Sep 30, 2008, 11:53:30 PM9/30/08
to perl58...@googlegroups.com
G'day Eddy,

Eddy S.Tan wrote:

> I've finished working on 2007-11-i. All changes are already pushed up to
> the branch...
> I'm unsure about a few items which are added to TODO file in branch
> 2007-11-i.

You rock! Changes reviewed and merged. Thank-you very much indeed!

Cheerio,

Reply all
Reply to author
Forward
0 new messages