Starting on 2007-11-a and 2007-11-b
Bradley Dean
I'll start working on 2007-11-a and 2007-11-b.
Cheerio,
Brad
--
Bradley Dean
Software Engineer - http://bjdean.id.au/
Email: bjd...@bjdean.id.au Skype: sk...@bjdean.id.au
Mobile(Aus): +61-413014395 Mobile(UK): +44-7846895073
Adam Flott
> I'll start working on 2007-11-a and 2007-11-b.
>
Noted in Volunteers.txt. Thanks a bunch!
Adam
Bradley Dean
there yet - more to come).
Bradley Dean
> I've started to push changes up on new branch 2007-11-a (not that many
> there yet - more to come).
Some more changes pushed on 2007-11-a.
Please note I made a commit (027d4d6b7929aa287dc2b147013921dc3bb31d0a)
which was not related to the branch as I noticed a typo in an adjacent
comment.
Bradley Dean
I've pushed put a comment into the TODO:
http://github.com/pfenwick/perl589delta/commit/d7d65bd1479421456490b84e13a43faf5ae46ddc
for change 32540.
I can see that some people might be interested in change in copyright for a
section of the source code so am thinking a subsection on copyright changes
might be worth including.
What do you guys think?
Paul Fenwick
Bradley Dean wrote:
> a few more changes pushed up to 2007-11-a - but a quick question for one and all.
Thank-you very much! You're awesome!
> I can see that some people might be interested in change in copyright for a
> section of the source code so am thinking a subsection on copyright changes
> might be worth including.
>
> What do you guys think?
Looking at the commit in question, this looks like a condensing of copyright
comments, rather than a change in copyright ownership. IANAL, but the end
effect of this on users should be nil. On that basis, I'd leave it out.
Of course, you're a member of the perl589delta target audience, so if you
think it's noteworthy, by all means include it.
All the best,
Paul
--
Paul Fenwick <p...@perltraining.com.au> | http://perltraining.com.au/
Director of Training | Ph: +61 3 9354 6001
Perl Training Australia | Fax: +61 3 9354 2681
Bradley Dean
> > I can see that some people might be interested in change in copyright for a
> > section of the source code so am thinking a subsection on copyright changes
> > might be worth including.
> >
> > What do you guys think?
>
> Looking at the commit in question, this looks like a condensing of copyright
> comments, rather than a change in copyright ownership. IANAL, but the end
> effect of this on users should be nil. On that basis, I'd leave it out.
I've left it out - I was tending towards that anyway so you've confirmed
what I thought. It can always be added later if someone thinks it's
important.
Bradley Dean
ok - 2007-11-a is done and pushed up.
I deleted splits/2007-11-a.txt from the branch and have created the
splits/DONE-2007-11-a.txt file (just added a copy of the file from the
master branch - I hope that's compatible with the way you've been adding
things Paul).
I'm hopping on a train to London now so can't do any more today - apologies
for not getting 2007-11-b done yet.
Cheerio,
Brad
Paul Fenwick
Bradley Dean wrote:
> I deleted splits/2007-11-a.txt from the branch and have created the
> splits/DONE-2007-11-a.txt file (just added a copy of the file from the
> master branch - I hope that's compatible with the way you've been adding
> things Paul).
You rock. 2007-11-a is merged, and Volunteers.txt is updated. Thank-you
very much indeed!
Cheerio,
Bradley Dean
It's not finished yet but I'm beginning to fall asleep. :)
Paul Fenwick
> I've just pushed a new branch for 2007-11-b
You're awesome, Brad. In line with trying to keep the master branch as
merged as possible I've merged these back into the master branch, but left
you as still working on the chunk.
Thanks again!
Bradley Dean
some more done tonight.
Bradley Dean
I've now finished and pushed the last of 2007-11-b up to github.
I've added a couple of TODO items (the one I mentioned and a check on a
the version of File::Copy).
Cheerio,
Brad
Paul Fenwick
Bradley Dean wrote:
> I've now finished and pushed the last of 2007-11-b up to github.
You rock. 2007-11-b has been merged into the main branch and pushed back to
github.
Many many many thanks!