2007-02-f

0 views
Skip to first unread message

LesleyB

unread,
Sep 23, 2008, 2:39:14 AM9/23/08
to The Perl 5.8.9 delta project
Hi

I think I have done as much as I can of 2007-02-f . The only trouble
is I didn't keep a DONE.2007-02-f while I was doing it. Do I need to
create one of those? (I can do this from diff.)

If so I have a question about it. The data is grouped into logical
elements headed by a patch number.
I have found most have been easy to dispense comletely but there was
especially one long one concerning perltodo which had elements that
included other stuff incomprehensible to me - or at least my brain
couldn't figure out what to say about them. So parts of the patch are
done and part isn't. I guess I should keep the patch header in the
TODO and DONE files?

My github account is LesleyB.

Regards

Lesley

Paul Fenwick

unread,
Sep 23, 2008, 2:49:42 AM9/23/08
to perl58...@googlegroups.com
G'day Lesley,

LesleyB wrote:

> I think I have done as much as I can of 2007-02-f . The only trouble
> is I didn't keep a DONE.2007-02-f while I was doing it. Do I need to
> create one of those? (I can do this from diff.)

You rock! Thank-you!

The DONE.* files are simply renames of the split files after they're
finished. They're to dissuade people from thinking chunks are available
when they're not. (Sometimes people are so enthusiastic they skip right
over the Volunteers.txt file).

> I have found most have been easy to dispense comletely but there was
> especially one long one concerning perltodo which had elements that
> included other stuff incomprehensible to me - or at least my brain
> couldn't figure out what to say about them. So parts of the patch are
> done and part isn't. I guess I should keep the patch header in the
> TODO and DONE files?

Actually, you can just document it in the TODO file. As long as you record
the patch number, we can always look it up in the original file (or on-line).

This is exactly the sort of situation the TODO file exists for.

> My github account is LesleyB.

You've been added as a collaborator. You *may* be able to tell your
existing git repo that it can commit back by editing the 'url' entry under
[remote "origin"] in your .git/config file to:

url = g...@github.com:pfenwick/perl589delta.git

However I haven't done that myself, so YMMV. I'd suggest taking a copy of
your entire directory first in case anything goes strangely.

If you've been making your changes to a branch, then you should be able to
push them with:

git push origin YOUR_BRANCH_NAME

If things don't work, patches work great. Provided you're at the head of
your branch, you can:

git format-patch master...HEAD

Cheerio,

Paul

--
Paul Fenwick <p...@perltraining.com.au> | http://perltraining.com.au/
Director of Training | Ph: +61 3 9354 6001
Perl Training Australia | Fax: +61 3 9354 2681

Reply all
Reply to author
Forward
0 new messages