Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Tcl.pm tests in repo but omitted from releases

2 views
Skip to first unread message

Christopher Chavez

unread,
Jul 15, 2018, 2:15:02 AM7/15/18
to tc...@perl.org
There’s a few tests in the git repository for Tcl.pm which aren’t in the releases (not in MANIFEST?):
dispsosal-subs-[abcdef].t, memleak-a.t, and set-callback.t.

Are these being excluded on purpose (i.e. they are developer-only rather than installation tests), or should they be included in releases?

Also, some of them (disposal-subs-a.t and memleak-a.t) use Devel::Refcount, which isn’t declared as a test dependency in Makefile.PL.

Konovalov, Vadim

unread,
Jul 15, 2018, 4:30:02 AM7/15/18
to Christopher Chavez, tc...@perl.org
> From: Christopher Chavez
> There's
> a few tests in the git repository for Tcl.pm which aren't in the releases (not
> in MANIFEST?):
> dispsosal-subs-[abcdef].t, memleak-a.t, and set-callback.t.

Nice catch.

Thank you, now fixed, :)

> Are
> these being excluded on purpose (i.e. they are developer-only rather than
> installation tests), or should they be included in releases?
>
> Also, some of
> them (disposal-subs-a.t and memleak-a.t) use Devel::Refcount, which isn't
> declared as a test dependency in Makefile.PL.

Right now I prefer to have fewer dependencies; however I will install Devel::Refcount on my PCs :)

huck

unread,
Jul 15, 2018, 5:45:03 PM7/15/18
to tc...@perl.org
This was my fault, thank you for fixing this for me.

The tests using Devel::Refcount get skipped if it is not installed. I
too didnt want to make the tests dependent on having it installed
0 new messages