summarize broken in HEAD

[salv...@gmx.ch]

summarize is broken, too, in HEAD as well as in commit ee01a07 (2014-12-22 15:01:12 -0800):

syntax error at ./summarize line 209, near "$message)
"
syntax error at ./summarize line 211, near "$message)"
Execution of ./summarize aborted due to compilation errors.

I'm puzzled by the error message though, because I don't see what could be wrong.

[John Crisp]

I *think* it is due to a couple of ')' - see the diff below which I
think may cure it (note I am a rank amateur at this and could be
completely wrong....)

I was trying to run this against an older version and that was the first
error it threw.


[me@home qpsmtpd_scripts]# diff -ruN summarize.pl.orig summarize.pl.new
--- summarize.pl.orig 2015-02-13 14:22:15.000000000 +0100
+++ summarize.pl.new 2015-02-13 14:45:04.000000000 +0100
@@ -205,10 +205,10 @@
return 'info', $pid, undef, undef, $message
if substr($message, 0, 13) eq 'Listening on ';

- return 'err', $pid, undef, undef, $message)
+ return 'err', $pid, undef, undef, $message
if $line =~ /at [\S]+ line \d/; # generic perl error
print "UNKNOWN LINE: $line\n";
- return 'unknown', $pid, undef, undef, $message);
+ return 'unknown', $pid, undef, undef, $message;
}

sub parse_line_plugin {



I also note that the log directories depend on $qpdir which would seems
to assume that the logs are elsewhere than /var/log

However, as the script also depends on other things like registry.txt
and therefore on other files in qpsmtpd/log which I do not have as my
version is too old, I never went further in hacking it to make it work.

B. Rgds
John

[John Crisp]

On 03/01/15 18:10, salv...@gmx.ch wrote:

[Hans Salvisberg]

Those have been fixed in the meantime.

(Hard to explain why I didn't see them when I posted the original
message...)

Hans