[perl #32356] [PATCH] update to embed.pod

[Stephane Payrard]

# New Ticket Created by Stephane Payrard
# Please include the string: [perl #32356]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org:80/rt3/Ticket/Display.html?id=32356 >

There is now a call to set the core and another to set the other
flags. I updated the code and the doc to reflect that.

--
stef

[Stéphane Payrard]

I apparently forgot to attach the file

[Leopold Toetsch]

Stéphane Payrard <st...@payrard.net> wrote:
>>
>> There is now a call to set the core and another to set the other
>> flags. I updated the code and the doc to reflect that.

Thanks, applied.
leo

[Brent 'Dax' Royal-Gordon]

On Mon, 8 Nov 2004 02:38:16 +0100, Stéphane Payrard <st...@payrard.net> wrote:
> + #include "parrot/parrot.h"
> #include "parrot/embed.h"

Unless things have changed far more than I thought, this is very,
very, very, very, very wrong. parrot.h is an internals-only
header--including it exposes all of Parrot's guts to the embedder.

Note this comment at the top of parrot.h:

# /* Only parrot core files should include this file.
# Extensions should include <parrot/extend.h>.
# Programs embedding parrot should include <parrot/embed.h>.
# */

And the define a few lines down:

# #define PARROT_IN_CORE

--
Brent 'Dax' Royal-Gordon <br...@brentdax.com>
Perl and Parrot hacker

There is no cabal.

[Dan Sugalski]

At 9:39 AM -0800 11/8/04, Brent 'Dax' Royal-Gordon wrote:
>On Mon, 8 Nov 2004 02:38:16 +0100, Stéphane Payrard <st...@payrard.net> wrote:
>> + #include "parrot/parrot.h"
>> #include "parrot/embed.h"
>
>Unless things have changed far more than I thought, this is very,
>very, very, very, very wrong. parrot.h is an internals-only
>header--including it exposes all of Parrot's guts to the embedder.

Definitely. It's:

*) parrot.h for internal code
*) extend.h for code writing extensions to parrot in C
*) embed.h for code embedding a parrot interpreter

Neither extend.h nor embed.h should include parrot.h.
--
Dan

--------------------------------------it's like this-------------------
Dan Sugalski even samurai
d...@sidhe.org have teddy bears and even
teddy bears get drunk

[Stéphane Payrard]

No need to modify embed.h.
Patch attached to get a snipped that compileds without the
#include "parrot/parrot.h"

--
stef

[Leopold Toetsch]

Stéphane Payrard <st...@payrard.net> wrote:
> Patch attached to get a snipped that compileds without the
> #include "parrot/parrot.h"

Thanks, applied.
leo