[perl #40319] [PATCH] PGE test file written in PIR revisited

[Nuno Carvalho]

# New Ticket Created by Nuno Carvalho
# Please include the string: [perl #40319]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40319 >

Hi parrot people,

Have done some cleannig in the file t/compilers/pge/06-grammar.t, also
haded one PMC to have an array of reasons to todo tests. Also haded a
new test grammar.

Attached to this message you can find a patch to
't/compilers/pge/06-grammar.t'.

Best regards,
./smash

[Patrick R. Michaud]

On Mon, Sep 11, 2006 at 08:32:26AM -0700, Nuno Carvalho wrote:
>
> Attached to this message you can find a patch to
> 't/compilers/pge/06-grammar.t'.

Many thanks for your excellent work on 06-grammar.t . It's
a nice addition.

After applying the patch, I get "1 subtest UNEXPECTEDLY SUCCEEDED".
I'm presuming it's test #10, which for some reason is marked "todo".
Is there a reason it's a "todo" test? (Apologies if this has already
been covered somewhere and I missed it.)

Pm

[Patrick R. Michaud]

On Mon, Sep 11, 2006 at 08:32:26AM -0700, Nuno Carvalho wrote:

> Have done some cleannig in the file t/compilers/pge/06-grammar.t, also
> haded one PMC to have an array of reasons to todo tests. Also haded a
> new test grammar.
>
> Attached to this message you can find a patch to
> 't/compilers/pge/06-grammar.t'.

Excellent!

Now applied, with a small fix to the "todo" logic (r14606), and
fixing PGE's bug that was the reason for the "todo" in the first place
(r14607).

Thanks!

Pm