Re: [perl #34002] [PATCH] 'const' for ParrotIOLayerAPI instances

[Leopold Toetsch]

François" PERRAD <parrotbug...@parrotcode.org> wrote:

> All instances of ParrotIOLayerAPI could be declared as 'const' in the IO
> subsystem.

Thanks, applied.
leo

[MrJoltCola]

Layer and layer API members may be changed at runtime. Yes, the current
structure
members are all static, but they don't have to be.

I would reverse this patch.

-Melvin

At 06:26 AM 1/31/2005, via RT wrote:
># New Ticket Created by François PERRAD
># Please include the string: [perl #34002]
># in the subject line of all future correspondence about this issue.
># <URL: https://rt.perl.org/rt3/Ticket/Display.html?id=34002 >

>
>
>
>All instances of ParrotIOLayerAPI could be declared as 'const' in the IO
>subsystem.
>

>I hope that it's an improvement (better & safer code) and not a problem for
>future feature.
>
>François Perrad
>

[Leopold Toetsch]

MrJoltCola <mrjol...@mindspring.com> wrote:
> Layer and layer API members may be changed at runtime. Yes, the current
> structure
> members are all static, but they don't have to be.

Please note: only the layer API was changed.

> I would reverse this patch.

A xxx_layer_api seems rather const to me, constituted from a bunch of
well defined functions. A different set of functions would create a
different API - probably.

> -Melvin

leo

[MrJoltCola]

They are well defined at the moment, but the author's intent of the API was
to have them
mutable.

-Melvin