Re: [perl #35900] [PATCH] skip dynclasses, spawnw tests on win32

0 views
Skip to first unread message

Leopold Toetsch

unread,
May 21, 2005, 3:41:34 AM5/21/05
to perl6-i...@perl.org
Jerry Gay <parrotbug...@parrotcode.org> wrote:

> dynclasses and spawnw have been busted on win32 for some time now.
> with this patch, these annoying test failures will be skipped on
> win32.

Good, just commit it ;-)

> ~jerry

leo

Ron Blaschke

unread,
May 21, 2005, 11:37:23 AM5/21/05
to jerry gay, Leopold Toetsch, perl6-i...@perl.org

Just my opinion on this: I'd rather see failures for things that need
to be fixed. Tests should only be skipped if they are not applicable
on the current system, or the test busts everything. Others may feel
different, of course.

Ron

Leopold Toetsch

unread,
May 22, 2005, 7:18:00 AM5/22/05
to Ron Blaschke, jerry gay, perl6-i...@perl.org
Ron Blaschke wrote:

[ skip dynclasses .t on Win32 ]

> Just my opinion on this: I'd rather see failures for things that need
> to be fixed. Tests should only be skipped if they are not applicable
> on the current system, or the test busts everything. Others may feel
> different, of course.

The old problem of skip, todo or let it fail.

Maybe we need pugs' test error classification scheme

> Ron

leo

Chromatic

unread,
May 23, 2005, 7:18:42 PM5/23/05
to Leopold Toetsch, p6i
On Sun, 2005-05-22 at 13:18 +0200, Leopold Toetsch wrote:

> The old problem of skip, todo or let it fail.
>
> Maybe we need pugs' test error classification scheme

I'll see what I can do with Parrot::Test.

-- c

Jerry Gay

unread,
May 24, 2005, 10:33:31 AM5/24/05
to chromatic, Leopold Toetsch, p6i
then i'll hold off on applying this patch

Chromatic

unread,
May 30, 2005, 6:19:02 PM5/30/05
to p6i
I've just added a feature to Parrot::Test to allow you to add todo =>
'reason' to the end of all test function calls. This will mark the
tests as TODO in a way that Test::Builder understands.

All failing TODO tests are successes in the eyes of the test harness and
do not appear in the short summary report. All succeeding TODO tests
are unexpected successes and raise a happy note in the short summary
report.

Adding TODO tests is a good way to write tests for things you know don't
work without making more failures than you want to record.

If there are no objections in a couple of days, I'll apply the patch
myself.

-- c

add_todo_caps.patch

Chromatic

unread,
Jun 2, 2005, 2:15:02 PM6/2/05
to p6i
On Mon, 2005-05-30 at 15:19 -0700, chromatic wrote:

> I've just added a feature to Parrot::Test to allow you to add todo =>
> 'reason' to the end of all test function calls. This will mark the
> tests as TODO in a way that Test::Builder understands.

> If there are no objections in a couple of days, I'll apply the patch
> myself.

I just applied this patch. TODO away!

-- c

Reply all
Reply to author
Forward
0 new messages