Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[perl #37399] [PATCH] fix imcc tests with bison >= 1.75c

3 views
Skip to first unread message

Joshua Hoblitt

unread,
Oct 10, 2005, 12:09:51 AM10/10/05
to bugs-bi...@rt.perl.org
# New Ticket Created by Joshua Hoblitt
# Please include the string: [perl #37399]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org/rt3/Ticket/Display.html?id=37399 >


This transaction appears to have no content

parrot-r9425-imcc_bison_1.75c.patch

Leopold Toetsch

unread,
Oct 10, 2005, 12:19:12 PM10/10/05
to perl6-i...@perl.org, bugs-bi...@netlabs.develooper.com
Joshua Hoblitt (via RT) wrote:

> According to the Bison Changlog, the error string "parse error" was
> changed to "syntax error" in bison 1.75c. I haven't tried that version
> but can confirm that it has changed in 1.875.

Or: unify the printed message in IMCC_fataly

Or: as these are regexen anyway ...

> -/^error:imcc:parse error, unexpected SHIFT_LEFT.*/
> +/^error:imcc:syntax error, unexpected SHIFT_LEFT.*/

... just test for (parse|syntax)

leo

Joshua Hoblitt

unread,
Oct 10, 2005, 3:45:12 PM10/10/05
to Leopold Toetsch, perl6-i...@perl.org, bugs-bi...@netlabs.develooper.com

I considered that but "syntax error" is specified by POSIX. Doesn't
really matter as longer as it will work with newer versions of Bison.

-J

--

Leopold Toetsch

unread,
Oct 10, 2005, 4:52:06 PM10/10/05
to Joshua Hoblitt, perl6-i...@perl.org, bugs-bi...@netlabs.develooper.com

I have no problem updating to a never bison version. Just OS/X is a bit
confusing:

$ bison --version
GNU Bison version 1.28

So if more folks can confirm that we want/need >= 1.75c, let's do it.

> -J

leo

Joshua Hoblitt

unread,
Oct 10, 2005, 5:03:38 PM10/10/05
to Leopold Toetsch via RT

I wouldn't really classify it as a 'need' but last release in the Bison
1.x series was 3 years ago. It would be 'nice' to work with
reasonably modern tools.

I've decided that I don't like accepting '(parse|syntax)' in the error
string as that could end up forcing end-user tests to accept both as
well. Lets either require Bison >= 1.75c or explicitly declare the
error messages.

Cheers,

-J

--

0 new messages