[perl #35361] [PATCH] Skip svn revision number if none exists

3 views
Skip to first unread message

Andy Dougherty

unread,
May 9, 2005, 1:22:31 PM5/9/05
to bugs-bi...@rt.perl.org
# New Ticket Created by Andy Dougherty
# Please include the string: [perl #35361]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org/rt3/Ticket/Display.html?id=35361 >


In a release tarball, the .svn directories don't exist, so
config/gen/revision.pl can't find the svn revision number. That's fine,
but it's probably wiser in that case to not report "failed" during the
Configure.pl process, but to simply skip over the missing number.

--- parrot-0.2.0/config/gen/revision.pl Thu Apr 14 10:27:32 2005
+++ parrot-andy/config/gen/revision.pl Mon May 9 10:13:28 2005
@@ -7,7 +7,8 @@

=head1 DESCRIPTION

-Determines parrot's revision.
+Determines parrot's SVN revision. In a release, there
+are no .svn directories, so this field is empty.

=cut

@@ -31,7 +32,7 @@
if ($revision >= 1) {
$Configure::Step::result = "r$revision";
} else {
- $Configure::Step::result = "failed";
+ $Configure::Step::result = "done";
}
}

--
Andy Dougherty doug...@lafayette.edu

Leopold Toetsch

unread,
May 10, 2005, 2:53:43 AM5/10/05
to perl6-i...@perl.org
Andy Dougherty (via RT) wrote:

> In a release tarball, the .svn directories don't exist, so
> config/gen/revision.pl can't find the svn revision number. That's fine,
> but it's probably wiser in that case to not report "failed" during the
> Configure.pl process, but to simply skip over the missing number.

Ouch, have missed that message.
Thanks, applied.

leo

Reply all
Reply to author
Forward
0 new messages