Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[perl #39829] [PATCH] accept() always fails

0 views
Skip to first unread message

Kay-Uwe Huell

unread,
Jul 13, 2006, 5:41:04 PM7/13/06
to bugs-bi...@rt.perl.org
# New Ticket Created by Kay-Uwe Huell
# Please include the string: [perl #39829]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=39829 >


Hi parrot,

unfortunatly you fail when I call your accept() op. I have fixed this
issue with attached patch.

You can test this with:
./parrot examples/io/httpd.pir

call http://localhost:1234/ from your browser.

$ ./parrot examples/io/httpd.pir
Binding to port 1234 on localhost.
The Parrot documentation can now be accessed at http://localhost:1234 .
accept: errno=22unknown method:''

Variable addrlen seems to be somehow optimized away.

DIFFSTAT:
CREDITS | 2 ++
src/io/io_unix.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)

happy hacking,

Kiwi

parrot_patch_1.patch

Leopold Toetsch

unread,
Jul 14, 2006, 5:56:14 AM7/14/06
to perl6-i...@perl.org, Kay-Uwe Huell, bugs-bi...@netlabs.develooper.com
Am Donnerstag, 13. Juli 2006 23:41 schrieb Kay-Uwe Huell:

> Hi parrot,
>
> unfortunatly you fail when I call your accept() op. I have fixed this
> issue with attached patch.

> The Parrot documentation can now be accessed at http://localhost:1234 .
> accept: errno=22unknown method:''

I don't get that error and I can't see, why changing the (not-reached)
diagnostic might fix accept.

The httpd.pir has different problems, though, which seem to be
protocol-related.

leo

Chris Dolan

unread,
Jul 14, 2006, 9:55:05 AM7/14/06
to Leopold Toetsch, perl6-i...@perl.org, Kay-Uwe Huell, bugs-bi...@netlabs.develooper.com

Kiwi,

I also don't experience this error but instead for me httpd.pir fails
at bind() [see RT #39738] on Darwin and FreeBSD. On which platform
does accept() fail for you? Which C compiler are you using? I agree
with Leo that your patch looks suspicious. If you are right that
just adding that diagnostic really does fix it, then it sounds like a
compiler bug that needs to be reported, or at least documented.

Chris

P.S. I've been working on some small improvements to httpd.pir,
including better failure diagnostics. Please contact me off-list for
a patch if you are interested.

--
Chris Dolan, Software Developer, http://www.chrisdolan.net/
Public key: http://www.chrisdolan.net/public.key
vCard: http://www.chrisdolan.net/ChrisDolan.vcf

Leopold Toetsch

unread,
Jul 17, 2006, 3:40:59 PM7/17/06
to perl6-i...@perl.org, Kay-Uwe Huell, bugs-bi...@netlabs.develooper.com
Am Donnerstag, 13. Juli 2006 23:41 schrieb Kay-Uwe Huell:
> Hi parrot,
>
> unfortunatly you fail when I call your accept() op.

This should be fixed now with r13332 (there was some confusion about sockaddr*
types and the len of these).

leo

0 new messages