Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Re: [perl #35413] [PATCH] r8062: convert internal exceptions to real exceptions - array

0 views
Skip to first unread message

Leopold Toetsch

unread,
May 12, 2005, 8:56:52 AM5/12/05
to perl6-i...@perl.org
Jerry Gay <parrotbug...@parrotcode.org> wrote:

> i'm converting many of the remaining internal_exception() calls to
> real_exception() (except unimplemented ops, and other valid internal
> exceptions)

Fine, thanks - applied.

Just curious: what's the difference between these two:

E_IndexError,
E_IndexOutOfBoundsError,

> before i send a list of patches for various files to the list, i'd
> like to make sure this first patch is agreeable.

Such patches are welcome. We can't usually just die, almost every error
should be catchable.

But please keep patches in reasoable size by e.g. converting just a few
execption types at once.

Thanks,
leo

Jerry Gay

unread,
May 12, 2005, 10:01:13 AM5/12/05
to l...@toetsch.at, perl6-i...@perl.org
On 5/12/05, Leopold Toetsch <l...@toetsch.at> wrote:
> Jerry Gay <parrotbug...@parrotcode.org> wrote:
>
> > i'm converting many of the remaining internal_exception() calls to
> > real_exception() (except unimplemented ops, and other valid internal
> > exceptions)
>
> Fine, thanks - applied.
>
> Just curious: what's the difference between these two:
>
> E_IndexError,
> E_IndexOutOfBoundsError,
>
the difference is very subtle ;)
i had made a somewhat larger list of error categories during my
patching process, then decided to roll some of them back. i missed
this one, so i've patched HEAD now (attached) to convert
E_IndexOutOfBoundsError back to E_IndexError, which is sufficent.

> > before i send a list of patches for various files to the list, i'd
> > like to make sure this first patch is agreeable.
>
> Such patches are welcome. We can't usually just die, almost every error
> should be catchable.
>
> But please keep patches in reasoable size by e.g. converting just a few
> execption types at once.
>

thanks for the reminder... i'll try to make it as easy for the
committers as i can.

> Thanks,
> leo
>
~jerry

indexerror.patch

Leopold Toetsch

unread,
May 13, 2005, 2:52:11 AM5/13/05
to jerry gay, perl6-i...@perl.org
Jerry Gay <jerr...@gmail.com> wrote:

> On 5/12/05, Leopold Toetsch <l...@toetsch.at> wrote:
>> Just curious: what's the difference between these two:
>>
>> E_IndexError,
>> E_IndexOutOfBoundsError,
>>
> the difference is very subtle ;)

Though so ;-)

> ... E_IndexOutOfBoundsError back to E_IndexError, which is sufficent.

Thanks, applied.
leo

0 new messages