Re: [perl #35116] [PATCH] Fix segfault when load_bytecode cannot find pbc file

0 views
Skip to first unread message

Chromatic

unread,
Apr 26, 2005, 5:41:04 PM4/26/05
to perl6-i...@perl.org, bugs-bi...@rt.perl.org
On Tue, 2005-04-26 at 11:55 -0700, Nick Glencross wrote:

> This patch fixes a segfault in r7928 when load_bytecode cannot find the
> pbc file. e.g.
>
> .sub test
> # (Assumes hello.pbc doesn't exist)
> load_bytecode "hello.pbc"
> end
> .end

Looks good to me.

Before I apply it, I think it needs a test case. I'll write it from
this example. How about t/stress/internal_exceptions.t?

Any other feedback?

-- c

Nick Glencross

unread,
Apr 26, 2005, 2:55:31 PM4/26/05
to bugs-bi...@rt.perl.org
# New Ticket Created by Nick Glencross
# Please include the string: [perl #35116]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org/rt3/Ticket/Display.html?id=35116 >


This patch fixes a segfault in r7928 when load_bytecode cannot find the
pbc file. e.g.

.sub test
# (Assumes hello.pbc doesn't exist)
load_bytecode "hello.pbc"
end
.end

Regards,

Nick

pbc_not_found_segfault.patch

Jens Rieks

unread,
Apr 26, 2005, 6:18:14 PM4/26/05
to perl6-i...@perl.org
On Tuesday 26 April 2005 23:41, chromatic wrote:
> Looks good to me.  
To me too, except...

> Before I apply it, I think it needs a test case.  I'll write it from
> this example.  How about t/stress/internal_exceptions.t?
>
> Any other feedback?

This should be a real_exception, not an internal one.

jens

Reply all
Reply to author
Forward
0 new messages