Re: [svn:parrot] rev 8004 - trunk/build_tools

[Leopold Toetsch]

lu...@cvs.perl.org <lu...@cvs.perl.org> wrote:

> Modified:
> trunk/build_tools/build_nativecall.pl
> Log:

> Added a seen hash so that we don't get redefinition errors when things
> are listed twice (as they probably ought to be if they're for specific
> libraries).

> + next if $seen{"$ret$;$args"}++;

This gives ugly warnings, if the call signature has no $args. But, we
have e.g.

i # void call, int ret
i v # same - explicit void call

These create of course the same code twice with different names. I tried
to remove signatures of the first type, but then Parrot PANICs during
startup.

What we really should do is:
- have just one of these equivalent signatures
- warn if there is a duplicate and ignore it

Patch reverted for now.

leo